Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fullnode RPC crashes if WriteTableItem has no data #13

Open
ownyrd opened this issue Jun 14, 2024 · 0 comments
Open

Fullnode RPC crashes if WriteTableItem has no data #13

ownyrd opened this issue Jun 14, 2024 · 0 comments

Comments

@ownyrd
Copy link

ownyrd commented Jun 14, 2024

Code Reference

WriteSetChange::WriteTableItem(write_table_item) => {
let data = write_table_item.data.as_ref().unwrap_or_else(|| {
panic!(
"Could not extract data from DecodedTableData '{:?}'",
write_table_item
)
});

Issue

For a Block with only Block Metadata and State Checkpoint (like https://0l.fyi/blocks/10901184) the Fullnode gRPC Endpoint GetTransactionsFromNode works as expected. A User Transaction will most likely crash the gRPC Server because there are (i think always) write_table_item types with data = null (see e.g. https://0l.fyi/transactions/21825188). I am not sure but I think those write_table_items are not as relevant as write_resource elements. So maybe we can consider setting this write_table_item to optional or at least allow null values. Currently this Endpoint is imo not usable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant