Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why do you want to check all cache sets in the prepare function? #7

Open
Yujie-Cui opened this issue Nov 5, 2022 · 0 comments
Open

Comments

@Yujie-Cui
Copy link

l1_monitorall(l1);

When I read this code, I found that l1_monitorall(l1) is executed in l1_prepare(); this is very strange? l1_prepare() seems to initialize variables and allocate memory. I think it might be some small mistake.

Because there is such a statement in the syncPrimeProbe() function:

  if (cachelevel == 1)
    lx = (lxpp_t)l1_prepare(NULL);
  else if (cachelevel == 2)
    lx = (lxpp_t)l2_prepare(NULL, NULL);

  lx_monitorall(lx);

It can be seen that after executing the l1_prepare function, the lx_monitorall() function is called. This means that lx_monitorall should not be included in the l1_prepare function, right?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant