Expose ProvenTransaction input and output note counts

[Mirko-von-Leipzig]

Currently the only way to access these counts is via their iterators, which is inefficient.

Context here.

[Fumuran]

@Mirko-von-Leipzig Probably I'm missing something, but why adding count methods to the AuthenticatedTransaction doesn't work? We can add somewhere here something like this:

    pub fn num_input_notes(&self) -> usize {
        self.inner.input_notes().num_notes()
    }

    pub fn num_output_notes(&self) -> usize {
        self.inner.output_notes().num_notes()
    }

We don't have count functions in ProvenTransaction, but we have such function in the corresponding input and output notes structs. Why can't we use them?

[Mirko-von-Leipzig]

@Mirko-von-Leipzig Probably I'm missing something, but why adding count methods to the AuthenticatedTransaction doesn't work? We can add somewhere here something like this:

    pub fn num_input_notes(&self) -> usize {
        self.inner.input_notes().num_notes()
    }

    pub fn num_output_notes(&self) -> usize {
        self.inner.output_notes().num_notes()
    }

We don't have count functions in ProvenTransaction, but we have such function in the corresponding input and output notes structs. Why can't we use them?

No 🤦 you are correct - no need for this functionality then.

I don't think I searched the documentation for num_xxx, was expecting a xxx_count. My bad :) And thank you for being more thorough.