serde: implementation for proven transaction #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbinth
previously requested changes
Dec 4, 2023
There was a problem hiding this comment.
Looks good! Thank you! I left some comments inline - many of them are related to the question whether we want to serialize all field or skip computed fields. The former is more performant, but the latter guarantees data integrity and should reduce attack surface a bit.
|
Btw, I think this will also close #6. |
This was referenced Dec 5, 2023
hackaugusto
force-pushed
the
hacka-serde-prove-transaction
branch
from
f1a74d0
to
afde61c
Compare
bobbinth
approved these changes
Dec 6, 2023
bobbinth
force-pushed
the
hacka-serde-prove-transaction
branch
from
afde61c
to
c38f083
Compare
|
I've updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as per the pr title.
fixes: #6