-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config: add systemd service files #265
Conversation
0e23523
to
10836cd
Compare
I am not very familiar with how systemd works - these files are so that we are able to run node/faucet as services, right? If so, maybe worth adding a bit more info about how they are to be used (in the relevant documentation files)? Also, is |
I think that we should not merge this PR for now, I agree that we should have managment for the faucet and node as services but we should wait for this issue to be closed first to make sure we have all the right paths and structure, etc...: #215 |
Added a bit of docs.
I have no preference, where do you want them?
These files can be updated if changes are necessary. |
10836cd
to
e380c81
Compare
I actually don't know what the best practices on this are. I'm assuming these are needed for node deployment but are separate from the docker build? Basically, how would these be used during deployment? For example, we have something like this:
Would these basically replace step 5 in the above with something like?:
|
Yes, systemd and docker are completely unrelated. The first would added to a package, say
Yeah, that would work too, but we would need to distribute the |
So - eventually, they would go into building of a Also, should we create an issue for building |
super seeded by #312 |
This adds a two minimal systemd files to run a
miden-node
andmiden-faucet
.These two service files are far from perfect, but it is nice to have them around if we need them once more.
For the moment the
faucet
is pigbacking in the node for the account details (from the genesis), and it removes the client's db on every restart. Both are not great, but to improve these the faucet needs to be improved. Which is at the moment is under development.