Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update documentation on running node with docker #289

Conversation

mFragaBA
Copy link
Contributor

When following the repo's documentation I was unable to run the node using docker. I explained in more detail on the discord server.

I saw that we have a docker-run-node command on Makefile.toml, tried it and the node started successfully.

@mFragaBA mFragaBA force-pushed the mFragaBA-use-cargo-make-docker-run-on-readme branch from d9c9abd to 3d195a8 Compare April 12, 2024 18:12
@bobbinth bobbinth force-pushed the next branch 2 times, most recently from 48004b0 to 4f67bfa Compare April 29, 2024 07:45
@bobbinth bobbinth changed the base branch from next to main April 29, 2024 08:01
@bobbinth bobbinth changed the base branch from main to next April 29, 2024 08:02
@bobbinth
Copy link
Contributor

@mFragaBA - should we resolve conflicts here and merge?

@bobbinth bobbinth requested a review from Dominik1999 April 29, 2024 08:02
@bobbinth
Copy link
Contributor

@mFragaBA, @igamigo - should we close this PR as stale or re-base and merge?

@mFragaBA
Copy link
Contributor Author

@mFragaBA, @igamigo - should we close this PR as stale or re-base and merge?

I'll close this since the change was already introduced to the README

@mFragaBA mFragaBA closed this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants