Tracking PR fo v0.6.0 release #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor: remove note details from sync responses * docs: update `CHANGELOG.md`
* fix: change field name in `GetAccountDetailsResponse` * update: CHANGELOG
…orageMode`, docs and miden-base using `next` (#489) * fix: replace AccountStub with AccountHeader, replace AccountStorageType with AccountStorageMode, update docs, update miden-base to use next branch * fix: update changelog
- builds packages - packages are deployed via S3
TryFrom implementation called `T::try_into` instead of `(*T)::try_into()` causing an infinite loop. This was introduced as part of a manual clippy fix where `x.clone().try_into()` was manually changed to `x.try_into()` instead of the suggested `(*x).try_into()`.
* fix: update to the latest `miden-objects` * refactor: remove use of `std::iter`
* feat: Add kernel root to block code * chore: Fix format * Make genesis kernel root default * Use current TransactionKernel::assembler_root() as for new block headers? * chore: Changelog * Add miden-lib to dependencies * Update block.proto * Alias generated module * Regen proto * Revert to good comment
* fix(WIP): update note tree depth in block kernel, update test * refactor: updated to the latest `miden-objects` * refactor: improve block kernel readability * fix: return back assertion in test * fix: compilation error * fix: update to the latest `miden-objects` * fix: update to the latest `miden-objects` * refactor: remove use of `std::iter` * chore: update `Cargo.lock` * chore: update `Cargo.lock` * chore: update `Cargo.lock`
* chore: Update to miden-base's next * chore: Lints * Correct genesis block kernel root * Remove error trace on faucet
… introduced in `miden-objects` (#503)
* feat: Add expiration num to mock tx builder * Revery miden-base branch * Lints
* feat: remove wallet from genesis config * fix: print message * feat: remove support of basic wallet in genesis file * docs: update CHANGELOG.md * Update CHANGELOG.md Co-authored-by: igamigo <[email protected]> --------- Co-authored-by: igamigo <[email protected]>
* feat: implement interface in proto * feat: implement `GetAccountStates` endpoint * docs: update CHANGELOG.md * refactor: simplify endpoint, address review comments * refactor: nit fixes * refactor: address review comments * chore: update to the latest `next` of `miden-base` * refactor: rename endpoint to `GetAccountProofs` * chore: remove unnecessary dependency * fix: don't query database if `include_headers` is `false` * refactor: address review comments
* feat: improve node errors * docs: update `CHANGELOG.md`
* feat: Return code for FPI * Rename var * CHANGELOG * Address comments * Check earlier * Address comments * Force proto rebuild * Update crates/rpc-proto/proto/responses.proto Co-authored-by: Mirko <[email protected]> * Update description * Proto rebuild * Update description --------- Co-authored-by: Mirko <[email protected]>
…532) * feat: avoid cloning in-memory data structures on `apply_block` * docs: update `CHANGELOG.md` * chore: update `miden-crypto` dependency Co-authored-by: Mirko <[email protected]> * Update CHANGELOG.md Co-authored-by: Mirko <[email protected]> * chore: update `Cargo.lock` * refactor: address review comments * fix: prevent inconsistent in-memory and DB states * refactor: address review comments --------- Co-authored-by: Mirko <[email protected]>
* feat: improve node errors * docs: update `CHANGELOG.md` * feat: save/restore faucet state and keypair to/from files * feat: make faucet account public, request account state on submission error * feat: introduce `ClientError` * fix: update config * fix: save new faucet state to in-memory store after getting from the server * fix: remove `macros` feature from axum dependency * docs: update `CHANGELOG.md` * docs: add comment for `seed` field Co-authored-by: Mirko <[email protected]> * fix: log message Co-authored-by: Mirko <[email protected]> * refactor: address review comments * refactor: initial changes * refactor: impl Send and Sync for FaucetDataStore * chore: update changelog * refactor: remove unnecessary async, add warning ignore to makefile * refactor: update genesis generation, read faucet account from `faucet.mac`, request faucet state on initialization * feat: faucet account creation * fix: handling of account not found error * refactor: use Arc and Mutex * chore: removed unneeded cast * fix: lint * docs: update CHANGELOG.md * fix: compilation errors * docs: add `TODO` for incorrect and unsafe `Send` implementation * refactor: small refactoring * refactor: address review comments * docs: update `README.md` for faucet * docs: improve instructions and clarifications in faucet's `README.md` --------- Co-authored-by: Mirko <[email protected]> Co-authored-by: Andrey <[email protected]> Co-authored-by: Bobbin Threadbare <[email protected]>
Clippy issue rust-lang/rust-clippy#12281 was fixed in v1.81. We now have MSRV of 1.82 allowing us to remove our workaround. More specifically, #[async_trait] was triggering this lint, and as of 1.81 no longer does.
* refactor: improve `ApplyBlockErrors` variants * docs: update `CHANGELOG.md` * refactor: address review comments
* Update state.rs * docs: Update expect() * chore: Lints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a tracking PR for v0.6.0 release.