feat(block-producer): arc transaction data #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbinth
approved these changes
Oct 28, 2024
Mirko-von-Leipzig
added a commit
that referenced
this pull request
Nov 3, 2024
This makes `AuthenticatedTransaction` much cheaper to clone and move around.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces deep cloning of transaction data in the new block-producer by wrapping the core data in
Arc.In addition, this PR also changes the dependency graphs key bound from
Clone -> Copy. This isn't strictly necessary, but does improve code readability as discussed here. Since our existing keys areCopythis doesn't actually have a further impact.Completes a task from #519.