fix: Return correct latest block number #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbinth
approved these changes
Nov 5, 2024
crates/store/src/state.rs
Outdated
| @@ -99,7 +99,7 @@ struct InnerState { | |||
| impl InnerState { | |||
| /// Returns the latest block number. | |||
| fn latest_block_num(&self) -> BlockNumber { | |||
| (self.chain_mmr.forest() + 1).try_into().expect("block number overflow") | |||
| (self.chain_mmr.forest() - 1).try_into().expect("block number overflow") | |||
There was a problem hiding this comment.
I would maybe add a safety comment here saying that chain_mmr always has at least one block (the genesis block) - and so this should be fine.
There was a problem hiding this comment.
Yeah, I thought of the potential underflow but realized it was not an issue but did not write a comment. Will add now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.