Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Now refers to sub-crates using paths (and removed patch section) #1222

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

BGluth
Copy link
Collaborator

@BGluth BGluth commented Sep 7, 2023

  • Previously refered to specific crates.io versions.
  • Motivation for this is to allow external projects to be able use specific revisions of this repo. Without this, a [patch] section is almost always required in the external project in order to force the internal plonky2 sub-crates to the same version, an approach which comes with its own issues.

- Previously refered to specific `crates.io` versions.
- Motivation for this is to allow external projects to be able use
  specific revisions of this repo. Without this, a `[patch]` section
  is almost always required in the external project in order to force
  the internal plonky2 sub-crates to the same version, an approach which
  comes with its own issues.
@BGluth BGluth requested a review from dlubarov September 7, 2023 22:37
@BGluth BGluth merged commit 65917f5 into main Sep 8, 2023
2 checks passed
@BGluth BGluth deleted the internal_crate_path_stablization branch September 8, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant