Feat/237 mpt trie ext to branch collapse error #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- While `Nibbles::default()` already does this, I think having an explicit method that makes an empty `Nibbles` is a bit cleaner, even if it's a bit redundant.
- Unsafe, as if the extension was pointing to a (hashed) leaf, then we must collapse the extension into the leaf. - However, because the leaf is hashed, we can not tell that the hash node is from a leaf and also can not extract the leaf's key. - It's the user's responsibility to ensure that this scenario never occurs, so we need to return an error when it does.
github-actions
bot
added
the
crate: mpt_trie
0xaatif
approved these changes
Aug 5, 2024
Nashtare
approved these changes
Aug 6, 2024
|
Ugh, how did I do that? I meant too just remove the changes of the calls to |
BGluth
added a commit
that referenced
this pull request
Aug 9, 2024
BGluth
force-pushed
the
feat/237_mpt_trie_ext_to_branch_collapse_error
branch
from
9b3e1b5 to
1c47d09
Compare
|
Should be good now. 👍 |
BGluth
added a commit
that referenced
this pull request
Aug 9, 2024
BGluth
force-pushed
the
feat/237_mpt_trie_ext_to_branch_collapse_error
branch
from
1c47d09 to
08543c2
Compare
BGluth
force-pushed
the
feat/237_mpt_trie_ext_to_branch_collapse_error
branch
from
08543c2 to
610c00b
Compare
atanmarko
pushed a commit
that referenced
this pull request
Aug 14, 2024
* Added `Nibbles::empty()` - While `Nibbles::default()` already does this, I think having an explicit method that makes an empty `Nibbles` is a bit cleaner, even if it's a bit redundant. * Now returns an error if we collapse an `E --> H` - Unsafe, as if the extension was pointing to a (hashed) leaf, then we must collapse the extension into the leaf. - However, because the leaf is hashed, we can not tell that the hash node is from a leaf and also can not extract the leaf's key. - It's the user's responsibility to ensure that this scenario never occurs, so we need to return an error when it does. * Requested PR changes for #455
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #237.
Also slipped in a QoL method
Nibbles::empty(), which maybe should have been a separate PR (sorry!). I felt that an explicitemptymethod was a bit more clear than callingNibbles::default()whenever we wanted an emptyNibbles.