Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle case when contract creation was reverted #482

Merged
merged 5 commits into from
Aug 15, 2024
Merged

handle case when contract creation was reverted #482

merged 5 commits into from
Aug 15, 2024

Conversation

temaniarpit27
Copy link
Contributor

@github-actions github-actions bot added the crate: zero_bin Anything related to the zero-bin subcrates. label Aug 9, 2024
@temaniarpit27 temaniarpit27 marked this pull request as ready for review August 9, 2024 09:55
@Nashtare Nashtare requested a review from atanmarko August 9, 2024 12:29
@Nashtare Nashtare added this to the Testing and Validation milestone Aug 9, 2024
Nashtare
Nashtare approved these changes Aug 14, 2024
View reviewed changes
Copy link
Collaborator

@Nashtare Nashtare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one non-blocking comment

zero_bin/rpc/src/native/txn.rs Outdated Show resolved Hide resolved
@Nashtare Nashtare linked an issue Aug 14, 2024 that may be closed by this pull request
handle case for contract deployment failure in native tracer #479
Closed
@temaniarpit27 temaniarpit27 requested a review from 0xaatif as a code owner August 15, 2024 04:27
@github-actions github-actions bot added the crate: trace_decoder Anything related to the trace_decoder crate. label Aug 15, 2024
@temaniarpit27 temaniarpit27 enabled auto-merge (squash) August 15, 2024 04:29
@temaniarpit27 temaniarpit27 merged commit f707882 into develop Aug 15, 2024
15 checks passed
@temaniarpit27 temaniarpit27 deleted the arpit/479 branch August 15, 2024 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atanmarko atanmarko atanmarko approved these changes

@0xaatif 0xaatif 0xaatif approved these changes

@Nashtare Nashtare Nashtare approved these changes

@muursh muursh muursh approved these changes

Assignees

@temaniarpit27 temaniarpit27

Labels
crate: trace_decoder Anything related to the trace_decoder crate. crate: zero_bin Anything related to the zero-bin subcrates.
Projects
Zero EVM
Status: Done
Milestone
Testing and Validation
Development

Successfully merging this pull request may close these issues.

handle case for contract deployment failure in native tracer
5 participants
@temaniarpit27 @muursh @atanmarko @Nashtare @0xaatif