Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use typed_mpt in the backend #494

Merged
merged 31 commits into from
Aug 15, 2024
Merged

Conversation

0xaatif
Copy link
Contributor

@0xaatif 0xaatif commented Aug 14, 2024

SMT stores AccountRlp in a fundamentally different way to MPT, so we need a StateTrie abstraction.
The other Trie types are QoL features to add more semantic meaning to e.g txn_ix -> TrieKey

Summary

  • storage_trie: HashedPartialTrie -> storage_trie: StorageTrie etc.
  • TriePath -> TrieKey, to not clash with mpt_trie::..::TriePath

Sorry for cherry-picking your commits @Nashtare, merging in develop what a nightmare for some reason

@0xaatif 0xaatif added this to the Type 1 - Q3 2024 milestone Aug 14, 2024
@0xaatif 0xaatif self-assigned this Aug 14, 2024
@github-actions github-actions bot added the crate: trace_decoder Anything related to the trace_decoder crate. label Aug 14, 2024
@0xaatif 0xaatif force-pushed the 0xaatif/typed-backend3 branch from 0f95a3a to 4689cd8 Compare August 14, 2024 15:15
@0xaatif 0xaatif enabled auto-merge (squash) August 14, 2024 16:34
@Nashtare
Copy link
Collaborator

@0xaatif no worries, I also hate you for having to merge latest decoder backend refactoring into continuations 😄 let's call it even!

Copy link
Contributor

@muursh muursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice indeed.

@0xaatif 0xaatif merged commit fb1aa3d into develop Aug 15, 2024
15 checks passed
@0xaatif 0xaatif deleted the 0xaatif/typed-backend3 branch August 15, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crate: trace_decoder Anything related to the trace_decoder crate.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants