-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use typed_mpt in the backend #494
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…race-decoder-decoding
github-actions
bot
added
the
crate: trace_decoder
Anything related to the trace_decoder crate.
label
Aug 14, 2024
0xaatif
force-pushed
the
0xaatif/typed-backend3
branch
from
August 14, 2024 15:15
0f95a3a
to
4689cd8
Compare
…488) * Fix precompile insertion in state trie * Reword
@0xaatif no worries, I also hate you for having to merge latest decoder backend refactoring into continuations 😄 let's call it even! |
muursh
reviewed
Aug 15, 2024
muursh
reviewed
Aug 15, 2024
muursh
reviewed
Aug 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice indeed.
muursh
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SMT stores
AccountRlp
in a fundamentally different way to MPT, so we need aStateTrie
abstraction.The other Trie types are QoL features to add more semantic meaning to e.g
txn_ix -> TrieKey
Summary
storage_trie: HashedPartialTrie
->storage_trie: StorageTrie
etc.TriePath
->TrieKey
, to not clash withmpt_trie::..::TriePath
Sorry for cherry-picking your commits @Nashtare, merging in
develop
what a nightmare for some reason