Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: trait StateTrie #542

Merged
merged 13 commits into from
Aug 28, 2024
Merged

refactor: trait StateTrie #542

merged 13 commits into from
Aug 28, 2024

Conversation

0xaatif
Copy link
Contributor

@0xaatif 0xaatif commented Aug 24, 2024

Blocked by #537

part of #275

Future implementors of StateTrie:

  • StateMpt
  • StateSmt

@github-actions github-actions bot added crate: trace_decoder Anything related to the trace_decoder crate. crate: evm_arithmetization Anything related to the evm_arithmetization crate. labels Aug 24, 2024
@0xaatif 0xaatif force-pushed the 0xaatif/typed-smt2 branch from 0aa8b41 to e0939d8 Compare August 27, 2024 09:23
@github-actions github-actions bot removed the crate: evm_arithmetization Anything related to the evm_arithmetization crate. label Aug 27, 2024
@0xaatif 0xaatif marked this pull request as ready for review August 27, 2024 09:24
.clone();
let mut state_trie = final_trie_state.state.clone();
state_trie.trim_to(
// This is a dummy payload, hence it does not contain yet
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// This is a dummy payload, hence it does not contain yet
// This is a dummy payload, hence it does not yet contain

Copy link
Contributor

@muursh muursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues on any of this from me. Nice job.

@0xaatif 0xaatif merged commit 00c759a into develop Aug 28, 2024
16 checks passed
@0xaatif 0xaatif deleted the 0xaatif/typed-smt2 branch August 28, 2024 15:28
@Nashtare Nashtare added this to the System strengthening milestone Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crate: trace_decoder Anything related to the trace_decoder crate.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants