-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: trait StateTrie #542
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
crate: trace_decoder
Anything related to the trace_decoder crate.
crate: evm_arithmetization
Anything related to the evm_arithmetization crate.
labels
Aug 24, 2024
0xaatif
force-pushed
the
0xaatif/typed-smt2
branch
from
August 27, 2024 09:23
0aa8b41
to
e0939d8
Compare
github-actions
bot
removed
the
crate: evm_arithmetization
Anything related to the evm_arithmetization crate.
label
Aug 27, 2024
muursh
reviewed
Aug 27, 2024
.clone(); | ||
let mut state_trie = final_trie_state.state.clone(); | ||
state_trie.trim_to( | ||
// This is a dummy payload, hence it does not contain yet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
// This is a dummy payload, hence it does not contain yet | |
// This is a dummy payload, hence it does not yet contain |
muursh
approved these changes
Aug 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues on any of this from me. Nice job.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by #537
part of #275
Future implementors of
StateTrie
:StateMpt
StateSmt