Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse txn rlp #547

Merged
merged 3 commits into from
Aug 26, 2024
Merged

Reuse txn rlp #547

merged 3 commits into from
Aug 26, 2024

Conversation

hratoanina
Copy link
Contributor

Addresses #539.

@github-actions github-actions bot added the crate: evm_arithmetization Anything related to the evm_arithmetization crate. label Aug 26, 2024
@hratoanina
Copy link
Contributor Author

hratoanina commented Aug 26, 2024 •
edited
Loading

Whoops, there's some noise from the previous PR, I'll rebase it first.
Done.

Nashtare
Nashtare approved these changes Aug 26, 2024
View reviewed changes
Copy link
Collaborator

@Nashtare Nashtare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice savings, LGTM!

evm_arithmetization/src/cpu/kernel/asm/transactions/type_0.asm Show resolved Hide resolved
@Nashtare Nashtare added this to the Performance Tuning milestone Aug 26, 2024
@hratoanina hratoanina merged commit 4ac1f5d into develop Aug 26, 2024
15 checks passed
@hratoanina hratoanina deleted the reuse_txn_rlp branch August 26, 2024 21:26
@hratoanina hratoanina mentioned this pull request Aug 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nashtare Nashtare Nashtare approved these changes

@muursh muursh Awaiting requested review from muursh

@LindaGuiga LindaGuiga Awaiting requested review from LindaGuiga LindaGuiga is a code owner

Assignees

@hratoanina hratoanina

Labels
crate: evm_arithmetization Anything related to the evm_arithmetization crate.
Projects
Zero EVM
Status: Done
Milestone
Performance Tuning
Development

Successfully merging this pull request may close these issues.
2 participants
@hratoanina @Nashtare