Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip missing Cancun bits for non Eth mainnet chains #605

Merged
merged 11 commits into from
Sep 12, 2024

Conversation

Nashtare
Copy link
Collaborator

@Nashtare Nashtare commented Sep 6, 2024

closes #562

Includes:

  • skipping missing header fields
  • updating decoder processing for pre-state execution (for now only beacon roots, feature gated to eth_mainnet)
  • add safeguards on all crates for conflicting features
  • have the trace_decoder directly take the burn_address from the data provided by the rpc module (for cdk_erigon feature)

Tested against a Polygon PoS RPC endpoint provided by @praetoriansentry and I managed to generate witness payloads with the rpc binary.

@Nashtare Nashtare added this to the Type 1 - Q3 2024 milestone Sep 6, 2024
@Nashtare Nashtare self-assigned this Sep 6, 2024
@github-actions github-actions bot added crate: trace_decoder Anything related to the trace_decoder crate. crate: proof_gen Anything related to the proof_gen crate. crate: evm_arithmetization Anything related to the evm_arithmetization crate. crate: zero_bin Anything related to the zero-bin subcrates. labels Sep 6, 2024
@Nashtare Nashtare force-pushed the feat/ignore_cancun_bits branch from 2a5f878 to 010c53a Compare September 7, 2024 20:38
proof_gen/src/lib.rs Outdated Show resolved Hide resolved
proof_gen/src/lib.rs Outdated Show resolved Hide resolved
@Nashtare
Copy link
Collaborator Author

The removal of trace_decoder/src/decoding.rs is to fix a merge issue missed in #551. It was initially removed in #583.

@Nashtare Nashtare merged commit fec2365 into develop Sep 12, 2024
18 checks passed
@Nashtare Nashtare deleted the feat/ignore_cancun_bits branch September 12, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crate: common crate: evm_arithmetization Anything related to the evm_arithmetization crate. crate: proof_gen Anything related to the proof_gen crate. crate: trace_decoder Anything related to the trace_decoder crate. crate: zero_bin Anything related to the zero-bin subcrates.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

CDK-Erigon / Polygon PoS: Skip missing Cancun header fields
3 participants