Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Current limitations of Plonky3 support for circuits3 #927

Open
4 of 5 tasks
codeblooded1729 opened this issue Nov 24, 2023 · 5 comments
Open
4 of 5 tasks

Current limitations of Plonky3 support for circuits3 #927

codeblooded1729 opened this issue Nov 24, 2023 · 5 comments
Assignees
@codeblooded1729

Comments

@codeblooded1729
Copy link
Contributor

codeblooded1729 commented Nov 24, 2023 •
edited
Loading

  • Can't use Mersenne-31 or BabyBear fields yet, since they have size smaller than 32 bit.
  • Update: Since the addition of symbolic builder, this is no longer an issue.
    Yet to figure out the analogue of constraint_degree in context of plonky3's uni_stark
  • Update: fixed in upstream now.
    Current verifer of uni_stark in plonky3 repo uses some hardcoded values. I have create a branch with temporary hack to solve this issue in our fork of plonky3, and using that branch in circuit3.

We would be using valida prover as an example for our vm. The functionalities which are yet to be implemented in valida as on 22 Jan 2024 are

  • Computation of quotient polynomial in prover (This is WIP, and supposedly finishes the prover Finishing the prover valida-xyz/valida#99)
  • Verifier is completely unimplemented. This is expected since the actual prover is incomplete.
@codeblooded1729 codeblooded1729 mentioned this issue Nov 24, 2023
Merged
codeblooded1729 added a commit that referenced this issue Nov 27, 2023
@codeblooded1729 @matthiasgoergens
Beginning of inclusion of plonky3 in circuits with BitShift Stark (#924)
0a362c0 
The PR marks the beginning of rewriting our circuits in plonky3. We are
experimenting with `uni_stark` crate for now.
Current limitations: #927

---------

Co-authored-by: Matthias Görgens <[email protected]>
@jdkanani
Copy link
Contributor

Who is working on this one? @phildimes @codeblooded1729

@matthiasgoergens
Copy link
Collaborator

Is recursion still open? What about verification?

@matthiasgoergens
Copy link
Collaborator

@codeblooded1729 I assigned this to you. That doesn't mean you need to fix all the problems, just to keep this list up to date. Thanks!

@codeblooded1729 codeblooded1729 mentioned this issue Jan 22, 2024
Closed
@matthiasgoergens
Copy link
Collaborator

Can't use Mersenne-31 or BabyBear fields yet, since they have size smaller than 32 bit.

We need to see about using multiple limbs for our 32 bit values?

@matthiasgoergens

This comment was marked as duplicate.

Sign in to view
@codeblooded1729 codeblooded1729 mentioned this issue Feb 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codeblooded1729 codeblooded1729

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@matthiasgoergens @jdkanani @codeblooded1729