Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing-beta #491

Merged
merged 17 commits into from
Nov 18, 2024
Merged

Fixing-beta #491

merged 17 commits into from
Nov 18, 2024

Conversation

Mati0x
Copy link
Collaborator

@Mati0x Mati0x commented Nov 5, 2024

  • Allocate button: rename allocation button into "Submit your support!" or "Submit Allocation"

  • Proposal page: chart scale should be based on threshold or max value like before

  • Adjust CVChart

  • Signaling pools: remove minimum conviction from edit settings page

  • Signaling pools: remove spending limit from edit settings page

  • Signaling pools: remove threshold from edit settings page

  • Pool form: Token address input: Remove garden token as default address

  • Pool card: Adjust pool cards height based on content

  • Cards: always ellipsis when overflow

  • Bug: Display correct funding token for active pools (kev is on it!)

  • Manage support button in proposalId page to redirect to to pool page and opens manage support

Suggestion:

  • remove pool id from PoolHeader (gonna do it in beta branch)

Copy link

vercel bot commented Nov 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gardens-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 18, 2024 9:21pm

@Mati0x
Copy link
Collaborator Author

Mati0x commented Nov 7, 2024

For ellipse when overflow, check with dev (is ok here ?) and merge this pr to beta
For adjust pool id in pool header also merge pr into beta first

Corantin
Corantin previously approved these changes Nov 11, 2024
Copy link
Contributor

@Corantin Corantin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't like the new card that wrapped the other cards :S
This PR:
image
Before:
image

@Mati0x Mati0x closed this Nov 15, 2024
@Mati0x Mati0x reopened this Nov 15, 2024
@Mati0x Mati0x merged commit 1f31225 into dev Nov 18, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants