Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shouldn't show red box when canceling dwell by turning off the dwell clicker #42

Open
1j01 opened this issue Aug 14, 2022 · 0 comments
Open
Labels
affects:desktop-app Affects the Electron app bug Something isn't working

Comments

@1j01
Copy link
Owner

1j01 commented Aug 14, 2022

Currently a red rectangle is shown around the border of the screen if you turn the dwell clicker off while a dwell is in progress.
It should simply show the dwell as canceled (ideally with an animation: #12)

The red rectangle represents an occluding element. There's no occluder in this case, but I see I do show_occluder_indicator(occluder || document.body);
Perhaps this is just a stopgap in lieu of a dwell click cancel animation? Or perhaps there's some case I'm not considering. I should take a peek at the git blame before changing this, but it's probably fine.

(The red dotted outline looks almost like it's starting to record the screen or something, when it covers the screen.)

@1j01 1j01 added bug Something isn't working affects:desktop-app Affects the Electron app labels Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects:desktop-app Affects the Electron app bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant