Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flysystem adapter for AsyncAws S3 #208

Closed
aziz-harazi opened this issue May 18, 2020 · 12 comments · Fixed by #209
Closed

Add flysystem adapter for AsyncAws S3 #208

aziz-harazi opened this issue May 18, 2020 · 12 comments · Fixed by #209

Comments

@aziz-harazi
Copy link

Hello, does the package will use async-aws/flysystem-s3 dependency instead of league/flysystem-aws-s3-v2soon ?

Thank you

@bytehead
Copy link
Member

It actually suggests to use league/flysystem-aws-s3-v3 if you want to use v3: https://github.com/1up-lab/OneupFlysystemBundle/blob/master/composer.json#L61

@aziz-harazi
Copy link
Author

Thank you for your response.
with oneup/flysystem-bundle, we have dependency with flysystem-aws-s3-v2(3) which have dependency aws/aws-sdk-php which is loading all services.

async-aws/flysystem-s3 has dependency with async-aws/core and async-aws/s3 we will not have to get all aws services.

Thank you and have a good day

@aziz-harazi
Copy link
Author

Are you going to include async-aws/flysystem-s3, in a future version ?

@bytehead
Copy link
Member

Yes that could be an enhancement!

@bytehead
Copy link
Member

I just don't have any time plan as my free time at the moment is quite limited.

@bytehead bytehead changed the title Dependency with async-aws/flysystem-s3 package Add flysystem adapter for AsyncAws S3 May 18, 2020
@bytehead
Copy link
Member

You could try to add your custom filesystem with https://github.com/1up-lab/OneupFlysystemBundle/blob/master/Resources/doc/adapter_custom.md and https://async-aws.com/integration/flysystem.html

@aziz-harazi
Copy link
Author

Thank you very much. I'm going to try it.

@bytehead
Copy link
Member

Did you end up successfully trying it via custom adapter?

@aziz-harazi
Copy link
Author

aziz-harazi commented May 25, 2020 via email

@Nyholm
Copy link
Contributor

Nyholm commented Jun 21, 2020

I added a PR for this in #209

@bytehead
Copy link
Member

Thank you Tobias! I'll check the PR asap :)

@bytehead
Copy link
Member

Closed in favor of #209

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants