Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android crash when scrolling in written sharing exercise in session #2678

Open
Greenheart opened this issue May 12, 2023 · 2 comments
Open
Labels
bug Something isn't working

Comments

@Greenheart
Copy link
Contributor

Greenheart commented May 12, 2023

What brings you here and how are you?

Just did the dive in exercise and liked it! Found a crash and a UX problem though.

Description

Two issues, maybe related:

  1. When writing a reflection in the session modal and scrolling up and down, this cause both the focused text input and the session modal itself to scroll in weird ways. It's like they both try to listen to scroll events at the same time.
  2. In one case this crashed the app and I lost my written text :(

Steps to Reproduce

  1. Open the dive in session, and skip to the written sharing exercise
  2. Focus the text input. Write something
  3. Try scrolling by pressing first in the text input and then in the session modal

Expected behavior:

First of all, the scroll should only happen on one element at a time. For example scrolling in the text input should not cause the session modal to also scroll.

Secondly, the app should not crash when scrolling.

Actual behavior:

The scroll is weird, consistently.

The app crashed once so I had to retype my reflection. From now on I'll type in another note app, and copy+paste into the Aware app to avoid having to deal with things like this.

Reproduces how often:

See above.

Versions

Version 2.25.0-v1279/P@028f3373

Additional Information

Android. See if you can find the Sentry crash report. Happened recently before this issue was opened.

@swemail
Copy link
Contributor

swemail commented May 12, 2023

Thanks @Greenheart! I could reproduce the crash and found that the error is in one of the libraries we use, it works as expected with this fix gorhom/react-native-bottom-sheet#1367 so we'll try to get that in asap

We've found that writing multiline text and scrolling inside it with the keyboard showing is an issue. Let's see what we can do about that. The crash must be fixed first, loosing what you wrote is a really bad experience. Sorry for that.

@Greenheart
Copy link
Contributor Author

Thanks! Keep it up :)

@jmpas jmpas added the bug Something isn't working label May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants