Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: baselayers selector #69

Open
1 task done
npltr62 opened this issue Feb 13, 2024 · 4 comments
Open
1 task done

[Bug]: baselayers selector #69

npltr62 opened this issue Feb 13, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@npltr62
Copy link
Contributor

npltr62 commented Feb 13, 2024

What is the bug?

when i clicked on baselayer selector, the baselayers switcher change but baselayers doesn't seems to change.

Steps to reproduce the issue

i use this script

Versions, safeguards, check summary etc

lizmap-web-client : 3.7.3
qgis-server: 3.34

Check Lizmap plugin

  • I have done the step just before in the Lizmap QGIS desktop plugin before opening this ticket. Otherwise, my ticket is not considered valid and might get closed.

Operating system

Windows 10

Browsers

Firefox

Browsers version

122.0.1

Relevant log output

No response

@npltr62 npltr62 added the bug Something isn't working label Feb 13, 2024
@gioman
Copy link
Contributor

gioman commented Feb 13, 2024

@npltr62 the logic for baselayers has changed in LMWC 3.7, so probably that script should be updated. This ticket has to be moved to https://github.com/3liz/lizmap-javascript-scripts/issues I guess.

@Gustry Gustry transferred this issue from 3liz/lizmap-web-client Feb 14, 2024
@audelorAd
Copy link

Hi,

I had this problem too with background_selector script
To solved it I add the code below at line 29 of the JS file.
lizMap.mainLizmap.state.baseLayers.selectedBaseLayerName = nextbl_val;
I'm not really sur that the right thing to do, but it seems to works well.

You'll also need to rename your png file to display your background preview, for example :
osm.png -> openStreetMap.png
ignphoto.png -> Orthophoto IGN.png

Hope this help.

@npltr62
Copy link
Contributor Author

npltr62 commented Feb 25, 2024

I had this problem too with background_selector script To solved it I add the code below at line 29 of the JS file. lizMap.mainLizmap.state.baseLayers.selectedBaseLayerName = nextbl_val; I'm not really sur that the right thing to do, but it seems to works well.

thanks this helped me a lot !

@npltr62 npltr62 closed this as completed Feb 25, 2024
@Gustry
Copy link
Member

Gustry commented Feb 26, 2024

Thanks for debugging.

Can you make a PR on GitHub ? You can just click the "pen" on GitHub, it will create the PR and commit automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants