Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetPrintAtlas does not work if ID of feature is not a number #71

Open
maxencelaurent opened this issue Jun 23, 2024 · 0 comments · May be fixed by #72
Open

GetPrintAtlas does not work if ID of feature is not a number #71

maxencelaurent opened this issue Jun 23, 2024 · 0 comments · May be fixed by #72

Comments

@maxencelaurent
Copy link

The plugin crashes when printing an atlas for a feature with string PK.

This issue is related to 3liz/lizmap-web-client#4534

Not sure to understand the current state of this plugin. Is it reaching it's end of life ?
Nonetheless, my current setup (LWC 3.7.8, qgis 3.34.7) still rely on it to print atlas from features pop-up.

I will file a PR very soon
maxencelaurent added a commit to maxencelaurent/lizmap-web-client that referenced this issue Jun 23, 2024
@maxencelaurent
[fix] print atlas
942e75c 
* quote string PK in order to generate a valid QGIS filter expression
* generate atlas according to `default_format` from layout config
* fixes 3liz#4534
* related to 3liz/qgis-atlasprint#71
maxencelaurent added a commit to maxencelaurent/qgis-atlasprint that referenced this issue Jun 23, 2024
@maxencelaurent
fix optimize_expression
f5eaff3 
* allow non-numeric PK expression optimization
* do not assume PK is the very first field of the list: use
  layer.primaryKeyAttributes() instead
* fixes 3liz/lizmap-web-client#4534
* related to 3liz#71
maxencelaurent added a commit to maxencelaurent/qgis-atlasprint that referenced this issue Jun 23, 2024
@maxencelaurent
fix optimize_expression
6701a06 
* allow non-numeric PK expression optimization
* do not assume PK is the very first field of the list: use
  layer.primaryKeyAttributes() instead
* fixes 3liz#71
* related to 3liz/lizmap-web-client#4534
@maxencelaurent maxencelaurent linked a pull request Jun 23, 2024 that will close this issue
Open
3liz-bot pushed a commit to 3liz/lizmap-web-client that referenced this issue Jul 1, 2024
@maxencelaurent @github-actions
[fix] print atlas
4ee911c 
* quote string PK in order to generate a valid QGIS filter expression
* generate atlas according to `default_format` from layout config
* fixes #4534
* related to 3liz/qgis-atlasprint#71
3liz-bot pushed a commit to 3liz/lizmap-web-client that referenced this issue Jul 1, 2024
@maxencelaurent @github-actions
[fix] print atlas
8768dca 
* quote string PK in order to generate a valid QGIS filter expression
* generate atlas according to `default_format` from layout config
* fixes #4534
* related to 3liz/qgis-atlasprint#71
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@maxencelaurent