Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and update DNS-resolver doc #1373

Open
mayorova opened this issue Aug 24, 2022 · 5 comments
Open

Review and update DNS-resolver doc #1373

mayorova opened this issue Aug 24, 2022 · 5 comments

Comments

@mayorova
Copy link
Contributor

mayorova commented Aug 24, 2022

The document https://github.com/3scale/APIcast/blob/bcd00e0/doc/dns-resolver.md mentions dnsmasq, howerver dnsmasq is not forming part of the APIcast image anymore, see #1090 and https://issues.redhat.com/browse/THREESCALE-1555.

Some other info in the doc might still be relevant though, but it needs to be reviewed and updated according to the current state.

@hector-vido
Copy link
Contributor

Hi @mayorova, how about add in docker-compose a dnsmasq container with --add-host pointing to Porta address and use --dns pointing to this new dnsmasq in apicast container?

If this looks good to you, I can add this to the project.

@tkan145
Copy link
Contributor

tkan145 commented Oct 31, 2023

@hector-vido I think the purpose of this ticket is to review and remove dnsmasq from the documentation since we no longer rely on dnsmasq to resolve DNS queries. Therefore, re-adding the dnsmasq container makes no sense to me.

@hector-vido
Copy link
Contributor

hector-vido commented Oct 31, 2023

@tkan145 sorry, I totally misunderstood and forgot that the containers will relay in docker internal DNS resolver and adding entries in our local /etc/hosts is enough. I was reading it from the perspective of a developer trying to test APICast, but I was wrong any way.

@tkan145
Copy link
Contributor

tkan145 commented Oct 31, 2023

No need to sorry 😃

fyi, the resolver logic is located here https://github.com/3scale/APIcast/blob/master/gateway/src/resty/resolver.lua

@akostadinov
Copy link

akostadinov commented Jun 11, 2024

Just FYI, adding entries to /etc/hosts is NOT enough. To run apicast locally in a container, we use a small proxy called porxy to be accessed by IP and relay requests to the porta server with the correct Host header.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants