Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoconfiguration is silently activated #23

Open
oudesnepelaar opened this issue Jun 3, 2024 · 0 comments
Open

Autoconfiguration is silently activated #23

oudesnepelaar opened this issue Jun 3, 2024 · 0 comments

Comments

@oudesnepelaar
Copy link

When one makes a mistake in configuring the 'success-url', the given value is ignored and a default Autoconfiguration value is used instead. This is not indicated by logging statements (even at DEBUG level), but is silently activated. One could for instance display a WARN or INFO level log line to show that Auto-config values are currently being used instead of the configured value, or show some indication that the value is unusable.

Apparently the value for 'success-url' is supposed to be formatted as a path, instead of as a URL. This means that the property name is misleading in a sense. Perhaps it is better to rename that property to 'success-path' instead. Or even better still wou;d be to also describe these expectation in a ReadMe or docs file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant