Skip to content
This repository has been archived by the owner on Jan 11, 2021. It is now read-only.

Makefile improvements #4

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

Conversation

tommai78101
Copy link
Contributor

@tommai78101 tommai78101 commented Nov 11, 2017

Changes:

  • Provided a better way to build relevant NTR payloads, depending on which targeted platform to build for (old_3ds, new_3ds, or both).
  • For old_3ds, made specific changes to build DSP using -O3, and use -Os for the rest.

44670 and others added 7 commits November 9, 2017 18:23
> <@profi200> It's borked beyond repair. Not sure you will get any standard build system working with it.
Added a TODO item to the Readme.md
replace python build "system" with Makefile
* old_3ds - For old 3ds
* new_3ds - For new 3ds
* both - For both devices.
@tommai78101 tommai78101 changed the title Added new make targets. Makefile improvements Nov 15, 2017
@tommai78101
Copy link
Contributor Author

On second thought, this Makefile improvement isn't really improving the build flow. What it does right now is, it runs Make twice, overriding the NEW_3DS flag set in the previous Make run, thus ignoring the DSP path to be compiled using -Os. I may need to rethink this at a later time.

@tommai78101
Copy link
Contributor Author

tommai78101 commented Nov 28, 2017

Going by WinterMute's suggestion, I added #pragma GCC optimize ("O3") to source/dsp source file, so it should theoretically override the flags set in the Makefile, and will compile with -O3 at all times for source codes marked with the #pragma GCC call. It is theoretical, because I'm not well-versed with #pragma GCC calls inside source codes.

@44670, what do you think about the #pragma GCC calls?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants