Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oai pmh openaire description with wrong variables #392

Closed
floriangantner opened this issue Oct 16, 2023 · 0 comments · Fixed by #394
Closed

oai pmh openaire description with wrong variables #392

floriangantner opened this issue Oct 16, 2023 · 0 comments · Fixed by #394
Labels

Comments

@floriangantner
Copy link

floriangantner commented Oct 16, 2023

Describe the bug
The service description of the openairecris oai pmh contains variables (from Dspace5) which are not substituted by default

To Reproduce
Steps to reproduce the behavior:

  1. curl some endpoint, e.g. curl https://tore.tuhh.de/dspace-cris-server/oai/openairecris?verb=Identify
	<WebsiteURL>${dspace.url}</WebsiteURL>
	<OAIPMHBaseURL>http://${dspace.hostname}/oai/openairecris</OAIPMHBaseURL>
  1. or curl some other endpoint https://publica-rest.fraunhofer.de/server/oai/openairecris?verb=Identify
	<WebsiteURL>https://publica.fraunhofer.de</WebsiteURL>
	<OAIPMHBaseURL>http://https://publica-rest.fraunhofer.de/server/oai</OAIPMHBaseURL>
  1. the OAI Base URL (https://github.com/4Science/DSpace/blob/dspace-cris-7/dspace/config/crosswalks/oai/service-description.xml) is substituted from some property dspace.hostname or dspace.url from dspace5 and thus left blank. Modifications in the configuration more or less lead to invalid urls.
  2. Note: changes on the configuration might have no effect if the oai.cache is oai.cache.enabled = true. The should be erased before!

Expected behavior
We expect to use the default dspace.server.url proeprty for this purpose.

Related work
Link to any related tickets or PRs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant