Unify Build & Manage tabs #7217
Conversation
ClementPasteau
force-pushed
the
unify-build-manage
branch
2 times, most recently
from
c4cc284 to
b1c9279
Compare
ClementPasteau
force-pushed
the
unify-build-manage
branch
from
9fee671 to
ed327ba
Compare
| ); | ||
| }; | ||
|
|
||
| const getFileNameWithoutExtensionFromPath = (path: string) => { |
There was a problem hiding this comment.
Will this work on Windows devices?
| @@ -247,17 +244,13 @@ export const PublicGamePropertiesDialog = ({ | |||
| disabled={isLoading} | |||
| canBePublishedOnGdGames={canBePublishedOnGdGames} | |||
| /> | |||
| {gameUnregisterErrorText && ( | |||
There was a problem hiding this comment.
removed this to make it an alert, allowing to re-use the same function to register in multiple places without having to handle where to display that errorText in each case
| @@ -383,7 +379,6 @@ export const initialPreferences = { | |||
| editorStateByProject: {}, | |||
| fetchPlayerTokenForPreviewAutomatically: true, | |||
| previewCrashReportUploadLevel: 'exclude-javascript-code-events', | |||
| gamesListOrderBy: 'createdAt', | |||
There was a problem hiding this comment.
removed the fact that we were saving the orderBy in the preferences, I feel it makes more sense to show always the latest one modified at the top as this will probably be the one you'll work on.
| <Text size="body-small" color="secondary"> | ||
| <Trans>{planCreditsAmount} credits</Trans> | ||
| </Text> | ||
| )} |
There was a problem hiding this comment.
those changes were to allow showing the marketing plans even if not logged in (in the performance dashboard)
I keep them for when we'll show the performance dashboard alltogether
| if (!name) throw new Error('A name was not chosen before saving as.'); | ||
| if (!authenticatedUser.authenticated) { | ||
| return { wasSaved: false, fileMetadata: null }; | ||
| } | ||
| options.onStartSaving(); | ||
|
|
||
| const gameId = saveAsLocation.gameId || project.getProjectUuid(); |
There was a problem hiding this comment.
this change allows saving the projectUuid on first save of the cloud project, even if not registered.
| @@ -171,6 +171,7 @@ export const ResponsiveLineStackLayout = ({ | |||
| <ColumnStackLayout | |||
| id={id} | |||
| noMargin={noMargin || noColumnMargin} | |||
| justifyContent={justifyContent} | |||
There was a problem hiding this comment.
we were never passing down the justifyContent to the column, when the mobile size kicks in.
I'm surprised we never needed this. I needed it to design properly a text being centered when going mobile
| @@ -261,7 +261,7 @@ export const clearCloudProjectCredentials = async (): Promise<void> => { | |||
|
|
|||
| export const createCloudProject = async ( | |||
| authenticatedUser: AuthenticatedUser, | |||
| cloudProjectCreationPayload: {| name: string, gameId?: string |} | |||
| cloudProjectCreationPayload: {| name: string, gameId: string |} | |||
There was a problem hiding this comment.
thanks to this, we shouldn't created a project without a gameId anymore
| fileMetadata, | ||
| storageProviderName: storageProviderInternalName, | ||
| }; | ||
| preferences.insertRecentProjectFile( |
There was a problem hiding this comment.
this is the fix to show the project in the recent files as soon as it is created with a chosen storage provider
| }: {| | ||
| project: gdProject, | ||
| isRemix?: boolean, |
There was a problem hiding this comment.
wasn't used
|
|
|
No description provided.