POC: Add supoort for multi language #158
Conversation
| "name": "LANG-KEY-str", | ||
| "full_name": "LANG-KEY-strength", | ||
| "desc": [ | ||
| "LANG-KEY-strength-measures-bodily-power-athletic-training-and-the-extent-to-which-you-can-exert-raw-physical-force", |
There was a problem hiding this comment.
Should these things instead be something like LANG-KEY-strength-description and store that as a list instead? A key like what we have right now seems a bit silly.
There was a problem hiding this comment.
It would probably make your hash in en.json be a little less ridiculious? Maybe?
There was a problem hiding this comment.
Should these things instead be something like
LANG-KEY-strength-descriptionand store that as a list instead? A key like what we have right now seems a bit silly.
Yes, this is totally what should happen. Having such big keys can be problematic on several fronts. The first and obvious one is that if typos are put in there, or on the contrary, fixed, we have to stick with what existed.
There was a problem hiding this comment.
If we want to keep the values the same type for everything, then the keys can instead be LANG-KEY-strength-description-#, where # is the index.
|
Hey, @carloslancha are you still working on this or is it on pause now? |
|
hey @bagelbits ! Sorry, I've been through a hard time (illness, work, coronastuff...). I'll take care of this when I have the time, it's being a crazy spring.... |
|
@carloslancha It has been. Please! Take all the time you need. There really is no rush. I just wanted to check in with you! |
What does this do?
Adds support for multi language, by splitting out text into a separate file that can be hot swapped for other languages.
How was it tested?
Unclear
Is there a Github issue this is resolving?
This addresses #81
Did you update the docs in the API? Please link an associated PR if applicable.
Not yet.
Here's a fun image for your troubles