perf(redirect): Don't get content from GitHub when redirection

Got content will never be used.
5ouma · Jun 18, 2024 · 5e93d78 · 5e93d78
1 parent 9c45275
commit 5e93d78
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 9 deletions.
diff --git a/src/libs/redirect.ts b/src/libs/redirect.ts
@@ -8,7 +8,7 @@ export function redirect<R extends string>(
   ctx: RouterContext<R>,
   userAgent: UserAgent,
   ref: string = "master",
-): void {
+): boolean {
   const repository = getRepository();
   const url = join(
     new URL("https://github.com"),
@@ -19,8 +19,9 @@ export function redirect<R extends string>(
     repository.path,
   );
 
-  if (userAgent?.browser.name) {
-    ctx.response.status = STATUS_CODE.PermanentRedirect;
-    ctx.response.redirect(url);
-  }
+  if (!userAgent?.browser.name) return false;
+
+  ctx.response.status = STATUS_CODE.PermanentRedirect;
+  ctx.response.redirect(url);
+  return true;
 }
diff --git a/src/router.ts b/src/router.ts
@@ -5,12 +5,10 @@ export const router = new Router();
 router
   .get("/", async <R extends string>(ctx: RouterContext<R>) => {
     ctx.response.type = "text/plain";
-    await getContent(ctx);
-    redirect(ctx, ctx.request.userAgent);
+    if (!redirect(ctx, ctx.request.userAgent)) await getContent(ctx);
   })
   .get("/:ref", async <R extends string>(ctx: RouterContext<R>) => {
     const ref: string | undefined = ctx.params.ref;
     ctx.response.type = "text/plain";
-    await getContent(ctx, ref);
-    redirect(ctx, ctx.request.userAgent, ref);
+    if (!redirect(ctx, ctx.request.userAgent, ref)) await getContent(ctx, ref);
   });