From 14325033be71674d12da7728a8b5951b837db277 Mon Sep 17 00:00:00 2001 From: Souma <101255979+5ouma@users.noreply.github.com> Date: Thu, 7 Nov 2024 19:54:00 +0900 Subject: [PATCH 1/4] refactor(ts): Don't write a `return` on a single state Arrow function can treat without a `return` state. --- src/server.ts | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/server.ts b/src/server.ts index 5e80c3e..d6c8f6f 100644 --- a/src/server.ts +++ b/src/server.ts @@ -54,6 +54,4 @@ app ? ctx.redirect(url.toString(), STATUS_CODE.PermanentRedirect) : ctx.text(...await getContent(repository, ref, GITHUB_TOKEN)); }) - .get("*", (ctx: Context) => { - return ctx.redirect("/", STATUS_CODE.SeeOther); - }); + .get("*", (ctx: Context) => ctx.redirect("/", STATUS_CODE.SeeOther)); From 4005cd995e0495d602c7e3864b4e58c94726c013 Mon Sep 17 00:00:00 2001 From: Souma <101255979+5ouma@users.noreply.github.com> Date: Thu, 7 Nov 2024 19:54:51 +0900 Subject: [PATCH 2/4] docs(pr_template): Move the description up Reviewers can notice the main info. --- .github/PULL_REQUEST_TEMPLATE.md | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index a977aa1..492f1c3 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -6,6 +6,16 @@ close #
+### โœ๏ธ Description + + + +
+ ### ๐Ÿ”„ Type of the Change - [ ] ๐ŸŽ‰ New Feature @@ -21,15 +31,5 @@ close #
-### โœ๏ธ Description - - - -
- - [ ] I agree to follow the [Code of Conduct](https://github.com/5ouma/reproxy/blob/main/.github/CODE_OF_CONDUCT.md). From 1be1d4e2c9c19df20d5e8f60509db235886bb2ba Mon Sep 17 00:00:00 2001 From: Souma <101255979+5ouma@users.noreply.github.com> Date: Thu, 7 Nov 2024 19:55:35 +0900 Subject: [PATCH 3/4] docs(readme): Remove the Codecov token It's not needed for the public repositories. --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 35c31d5..ca3149f 100644 --- a/README.md +++ b/README.md @@ -16,7 +16,7 @@ [![CI](https://img.shields.io/github/actions/workflow/status/5ouma/reproxy/ci.yml?label=ci&style=flat-square)](https://github.com/5ouma/reproxy/actions/workflows/ci.yml) [![Release](https://img.shields.io/github/actions/workflow/status/5ouma/reproxy/release.yml?label=release&style=flat-square)](https://github.com/5ouma/reproxy/actions/workflows/release.yml) [![pre-commit.ci status](https://results.pre-commit.ci/badge/github/5ouma/reproxy/main.svg?style=flat-square)](https://results.pre-commit.ci/latest/github/5ouma/reproxy/main) -[![codecov](https://codecov.io/github/5ouma/reproxy/graph/badge.svg?token=OQB55KXJIL)](https://codecov.io/github/5ouma/reproxy) +[![codecov](https://codecov.io/github/5ouma/reproxy/graph/badge.svg)](https://codecov.io/github/5ouma/reproxy) From 3958753da611a9690482d8f2e4b6e00590fe1aec Mon Sep 17 00:00:00 2001 From: Souma <101255979+5ouma@users.noreply.github.com> Date: Thu, 7 Nov 2024 19:56:17 +0900 Subject: [PATCH 4/4] ci(ci): Add the word "check" for job names It actually doesn't modify files. --- .github/workflows/ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 738ac64..a0c0e03 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -16,7 +16,7 @@ on: jobs: lint: - name: ๐Ÿงน Lint + name: ๐Ÿงน Lint Check runs-on: Ubuntu-Latest steps: @@ -33,7 +33,7 @@ jobs: run: deno doc --lint ./src format: - name: ๐Ÿ“ Format + name: ๐Ÿ“ Format Check runs-on: Ubuntu-Latest steps: