Use historic BTC rate for expense items; allow BTC as currency #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just used this PR to submit the latest reimbursement, which spans a few months. The historic rates in storage go back to August 1, 2024 as of now (but can be extended if necessary). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fetches historic rates when adding expense items where the date is not the current day (still using current rate otherwise). The API for this is just JSON objects posted to a public category in our
[email protected]user's remoteStorage account (implementation for that following separately).Also allows to add expense items with BTC as currency, which forgoes the currency conversions.
Both for transparency and accurate implementation, there is now also an additional sats amount stored with each line item in the expense list for every expense, no matter if it's EUR, USD, or BTC.
closes #225
Edit: I just realized that for the
amountSatsto be included in the IPFS docs, it needs to be added to the kredits JS library first. Added an issue for it.