Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs_config_generator.py fsconfig: error: argument --all-partitions: expected one argument #5

Open
imvipgit opened this issue Mar 26, 2019 · 4 comments

Comments

@imvipgit
Copy link

solved by changing aosp\out\build-hikey970.ninja,
two places,
command = /bin/bash -c "build/make/tools/fs_config/fs_config_generator.py fsconfig --aid-header system/core/include/private/android_filesystem_config.h --capability-header bionic/libc/kernel/uapi/linux/capability.h --partition system --all-partitions '' --dirs --out_file out/target/product/hikey970/obj/ETC/fs_config_dirs_system_intermediates/fs_config_dirs_system /dev/null"

command = /bin/bash -c "build/make/tools/fs_config/fs_config_generator.py fsconfig --aid-header system/core/include/private/android_filesystem_config.h --capability-header bionic/libc/kernel/uapi/linux/capability.h --partition system --all-partitions '' --files --out_file out/target/product/hikey970/obj/ETC/fs_config_files_system_intermediates/fs_config_files_system /dev/null"

@pundiramit
Copy link

vendor partition is missing? vendor partition is no longer optional.

@GensaGames
Copy link

I'm sure there is right way to change script in build folder.
Any updates on this?

Thanks,

@pundiramit
Copy link

You can modify it locally anyway you want but that change is highly unlikely to go in AOSP. But yeah you can modify the script and other dependencies if any.

For an older device of mine, I use cache (now obsolete) partition as vendor partition. That way I don't have to worry about modifying the existing partition layout.

@imvipgit
Copy link
Author

in the end, this did not work for me. can't put all together when compiling AOSP branch (Pie) , problem is non-treble compliance of this repo.
Has anyone successfully compiled and run AOSP P on Hikey970 board WITH (separate /vendor partition for all SOC/HW acceleration specific components) OR WITHOUT (/system/vendor as Android N) treble compliance ???
I have managed to solve other errors but failed in the end 99% compiling vendor.img because of lack of treble support from the branch. error: "You cannot install files to out/target/product/hikey970/system/vendor while building a separate vendor.img!"; tried compiling vendor partion by enabling BOARD_VENDORIMAGE_FILE_SYSTEM_TYPE but looks like this is going to be huge work if i proceed in this direction. all the VINTF, HIDL implementation.. :(

Any help or guidance greatly appreciated.
Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants