Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency on rmdir #38

Open
jpgrace opened this issue Feb 9, 2019 · 3 comments
Open

Remove dependency on rmdir #38

jpgrace opened this issue Feb 9, 2019 · 3 comments

Comments

@jpgrace
Copy link

jpgrace commented Feb 9, 2019

There is a moderate severity security issue with one of your dependencies (i.e., the path to the vuln serverless-localhost > rmdir > node.extend.

It looks like the easiest fix is to just stop using rmdir since it doesn't do much and hasn't been updated in quite a while. Let me know if you'd like me to submit a PR.

More info: https://npmjs.com/advisories/781
@jpgrace jpgrace mentioned this issue Feb 15, 2019
Open
@rehrumesh
Copy link
Contributor

Hi @jpgrace thanks for pointing this out. Also its great that you had opened a PR. I've added a comment can you check?

@HHK1 HHK1 mentioned this issue Feb 25, 2019
Open
@jpgrace
Copy link
Author

jpgrace commented Feb 25, 2019

Hi @rehrumesh, I've responded to your comment.

@RishikeshDarandale
Copy link

@AshanFernando , this is resolved in #40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jpgrace @rehrumesh @RishikeshDarandale