-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cant reload file with typescript lsp #75
Closed
Comments
to be clear this is when files are changed inside acme, not by an outside process like #6 |
farhaven
added a commit
to farhaven/go-lsp-internal
that referenced
this issue
Jun 12, 2024
The Typescript language server [checks ranges only for equality to `undefined`](https://github.com/microsoft/vscode-languageserver-node/blob/1ce790dd341a38da1fbf902cddc16ce456149de0/protocol/src/common/protocol.ts#L1915) to determine if a change is incremental. This means that unset ranges need to be omitted completely from the generated messages instead of encoding them as `null`. Fixes 9fans/acme-lsp#75
Reopening because we still need to update acme-lsp's dependency on go-lsp-internal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
So the typescript lsp works pretty well when reading a file, I get diagnostics and hover info, but if I modify the file and Put, it's new state is never reloaded. Even if I click on Get in the file and / or Reload in the diagnostics window.
The only thing to do is restart the lsp or restart acme-lsp on file change, which is a bit annoying haha.
The text was updated successfully, but these errors were encountered: