refactor: member, job 의존성 분리

[koosco]

🚀 개요
close #42
🔍 변경사항
변경사항 1: Job에 있는 Member 의존성을 InterestJob으로 이동
변경사항 2
변경사항 3
⏳ 작업 내용
작업 내용 1
작업 내용 2
작업 내용 3
📝 논의사항

Summary by CodeRabbit

• New Features

  • Introduced centralized constants for security configurations, enhancing maintainability.
  • Updated OAuth handling for Kakao API to improve code readability and consistency.

• Bug Fixes

  • Streamlined member handling in job services, improving the efficiency of job saving processes.

• Refactor

  • Simplified method signatures and internal logic for better clarity and performance across services.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request primarily involve modifications to security configurations and job services within the application. The SecurityConfig class now references allowed URLs from a new SecurityConst class, which centralizes security-related constants. Additionally, the KakaoApiClient and AuthTokenGenerator classes have been updated to utilize constants for improved maintainability. The InterestJobService and JobCommandService classes have also been modified to streamline member handling by shifting from Member objects to using memberId directly.

Changes

File Path	Change Summary
src/main/java/com/groom/orbit/config/security/SecurityConfig.java	Removed allowedUrls, replaced with static import of ALLOWED_URLS from SecurityConst.
src/main/java/com/groom/orbit/config/security/SecurityConst.java	Added class with constants for security configurations, including AUTHORIZATION_HEADER, TOKEN_PREFIX, and ALLOWED_URLS.
src/main/java/com/groom/orbit/config/security/kakao/KakaoApiClient.java	Updated to use constants for OAuth requests, replacing hardcoded strings with constants from KakaoSecurityConst.
src/main/java/com/groom/orbit/config/security/kakao/KakaoSecurityConst.java	Added class with constants related to Kakao security configurations, including grant types and URIs.
src/main/java/com/groom/orbit/config/security/oAuth/AuthTokenGenerator.java	Removed local constants for token expiration times and bearer token, now imported from SecurityConst.
src/main/java/com/groom/orbit/job/app/InterestJobService.java	Modified saveInterestJob to accept Long memberId instead of Member, added MemberQueryService.
src/main/java/com/groom/orbit/job/app/JobCommandService.java	Removed MemberQueryService, updated saveInterestJob to directly use memberId.

Possibly related PRs

• refactor: ArgumentResolver 적용 #48: The changes in QuestQueryController.java involve the addition of the @AuthMember annotation to the findQuest method, which relates to the security context similar to the modifications made in SecurityConfig.java regarding URL authorization.

🐰 In the land of code, where changes bloom,
Security's tightened, dispelling the gloom.
Constants now guide, like stars in the night,
OAuth flows smoother, everything feels right.
With member IDs clear, we hop without fear,
In the garden of code, new features appear! 🌼✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.