Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for symbolic links #50

Open
dpastoor opened this issue Sep 2, 2023 · 1 comment
Open

Add support for symbolic links #50

dpastoor opened this issue Sep 2, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@dpastoor
Copy link
Member

dpastoor commented Sep 2, 2023

There isn't really a need for many of these files to actually have them in the repository itself, rather could instead just link. We'd need to protect the file from being modified though by the user so in the process of linking would want to set the file to read-only. This could cause confusion to users if they later try to modify since they'd get generic permissions errors

impact assessment

  • status/ls would need to follow symlinks to original file
  • mechanism for user to know which files from dvs were linked vs copies
  • undo or swap link to original
  • IO considerations - if the project dir itself is on one FS vs the original data on separate one, this could cause performance changes in the repo activities itself based on where subsuquent read IO would be handled against
  • migration of dvs root directories would be much more risky

implementation timeline

for now just tracking this idea, no need to implement unless the burden of copying files becomes a common point of feedback

@andriygm andriygm added the enhancement New feature or request label Sep 4, 2023
@andriygm
Copy link
Member

andriygm commented Oct 11, 2023

would this feature symlink project files to the files in storage? if we do S3 we may want to symlink the project files instead to the cache, and dvs get into said cache instead (I believe this is how dvc works as well but I could be mistaken)

@andriygm andriygm changed the title dvs get --link to just symlink as read-only Add support for symbolic links Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants