From 96c84ee3f9f257ae76ec75e5d5caf605c514d7bf Mon Sep 17 00:00:00 2001 From: Jenna Johnson Date: Fri, 1 Nov 2024 16:08:09 +0000 Subject: [PATCH 1/3] fixes logo in report overlapping with header line --- R/scrape.R | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/R/scrape.R b/R/scrape.R index f1f3dc5..e62f2be 100644 --- a/R/scrape.R +++ b/R/scrape.R @@ -375,7 +375,7 @@ create_intro <- function(repo, milestone_names) { - \\newcolumntype{{R}}[1]{{>{{\\raggedright\\arraybackslash}}p{{#1}}}} - \\newcommand{{\\blandscape}}{{\\begin{{landscape}}}} - \\newcommand{{\\elandscape}}{{\\end{{landscape}}}} - - \\fancyhead[R]{{\\includegraphics[width=2cm]{{{image_path}}}}} + - \\fancyhead[R]{{\\includegraphics[width=2cm, height=1.5cm]{{{image_path}}}}} - \\fancyhead[C]{{}} - \\fancyhead[L]{{}} - \\setlength{{\\headheight}}{{30pt}} @@ -383,7 +383,7 @@ create_intro <- function(repo, milestone_names) { - \\usepackage{{lastpage}} - \\lstset{{breaklines=true}} - \"\\\\fancypagestyle{{plain}}{{\" - - \"\\\\fancyhead[R]{{\\\\includegraphics[width=2cm]{{{image_path}}}}}\" + - \"\\\\fancyhead[R]{{\\\\includegraphics[width=2cm, height=1.5cm]{{{image_path}}}}}\" - \"\\\\renewcommand{{\\\\headrulewidth}}{{0.4pt}}\" - \"}}\" output: From 704657c449dd084eeb99cf427166ec946153fc9f Mon Sep 17 00:00:00 2001 From: Jenna Johnson Date: Fri, 1 Nov 2024 16:10:16 +0000 Subject: [PATCH 2/3] updates version to 0.1.7 and updates NEWS.md --- DESCRIPTION | 2 +- NEWS.md | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/DESCRIPTION b/DESCRIPTION index 3b492fa..080e6d7 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -1,6 +1,6 @@ Package: ghqc.app Title: Create QC Checklists in Github Issues -Version: 0.1.6 +Version: 0.1.7 Authors@R: c( person("Jenna", "Johnson", email = "jenna@a2-ai.com", role = c("aut", "cre")), person("Anne", "Zheng", email = "anne@a2-ai.com", role = c("aut")), diff --git a/NEWS.md b/NEWS.md index ac58f54..a87566e 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,3 +1,7 @@ +# ghqc.app 0.1.7 + +- Fixes bug in rendered reports in which a maximum height for logos wasn't set to prevent overlapping header lines and header text. + # ghqc.app 0.1.6 - Fixes bug in record app for previewing markdown files (same bug and solution as in 0.1.4) From 8e3369d10ed2bff443e72815a90138a640c9437f Mon Sep 17 00:00:00 2001 From: Jenna Johnson Date: Fri, 1 Nov 2024 16:29:03 +0000 Subject: [PATCH 3/3] add keepaspectratio --- R/scrape.R | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/R/scrape.R b/R/scrape.R index e62f2be..6216d8d 100644 --- a/R/scrape.R +++ b/R/scrape.R @@ -375,7 +375,7 @@ create_intro <- function(repo, milestone_names) { - \\newcolumntype{{R}}[1]{{>{{\\raggedright\\arraybackslash}}p{{#1}}}} - \\newcommand{{\\blandscape}}{{\\begin{{landscape}}}} - \\newcommand{{\\elandscape}}{{\\end{{landscape}}}} - - \\fancyhead[R]{{\\includegraphics[width=2cm, height=1.5cm]{{{image_path}}}}} + - \\fancyhead[R]{{\\includegraphics[width=2cm, height=1.5cm, keepaspectratio]{{{image_path}}}}} - \\fancyhead[C]{{}} - \\fancyhead[L]{{}} - \\setlength{{\\headheight}}{{30pt}} @@ -383,7 +383,7 @@ create_intro <- function(repo, milestone_names) { - \\usepackage{{lastpage}} - \\lstset{{breaklines=true}} - \"\\\\fancypagestyle{{plain}}{{\" - - \"\\\\fancyhead[R]{{\\\\includegraphics[width=2cm, height=1.5cm]{{{image_path}}}}}\" + - \"\\\\fancyhead[R]{{\\\\includegraphics[width=2cm, height=1.5cm, keepaspectratio]{{{image_path}}}}}\" - \"\\\\renewcommand{{\\\\headrulewidth}}{{0.4pt}}\" - \"}}\" output: