From f402683804a96493270132b102a7bee4217e963b Mon Sep 17 00:00:00 2001
From: Jenna Johnson <jenna@a2-ai.com>
Date: Wed, 30 Oct 2024 13:56:02 +0000
Subject: [PATCH 1/3] fix bug in milestone hyperlinks in record warning modal

---
 R/app_03_record_utils.R | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/R/app_03_record_utils.R b/R/app_03_record_utils.R
index 3b0b5e2..550100e 100644
--- a/R/app_03_record_utils.R
+++ b/R/app_03_record_utils.R
@@ -1,6 +1,7 @@
 #' @importFrom log4r warn error info debug
 generate_html_list_with_hyperlink <- function(items) {
-  paste("<li><a href='", items$url, "' target='_blank'>", items$title, "</a></li>", collapse = "")
+  html <- paste("<li><a href='", items$url, "' target='_blank'>", items$title, "</a></li>", collapse = "")
+  html
 }
 
 generate_tiered_html_list_with_hyperlink <- function(items) {
@@ -8,7 +9,7 @@ generate_tiered_html_list_with_hyperlink <- function(items) {
 
   milestone_sections <- lapply(names(milestone_dfs), function(milestone_name) {
     milestone_url <- milestone_dfs[[milestone_name]]$milestone_url[1]
-    milestone_heading <- glue::glue("<a href='{milestone_url}'>{milestone_name}</a>:")
+    milestone_heading <- glue::glue("<a href='{milestone_url}' target='_blank'>{milestone_name}</a>:")
 
     milestone_list_items <- paste(
       "<li><a href='",

From a55a4a8db3bb01c49d798cbec043a78ab55dc10a Mon Sep 17 00:00:00 2001
From: Jenna Johnson <jenna@a2-ai.com>
Date: Wed, 30 Oct 2024 14:31:21 +0000
Subject: [PATCH 2/3] Change wording in report warning popup when there are no
 milestones - add reset button to modal

---
 R/app_03_record_server.R | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/R/app_03_record_server.R b/R/app_03_record_server.R
index ef736d0..0fe25bf 100644
--- a/R/app_03_record_server.R
+++ b/R/app_03_record_server.R
@@ -35,13 +35,17 @@ ghqc_record_server <- function(id, remote, org, repo, all_milestones) {
               modalDialog(
                 title = tags$div(
                   tags$span("Warning", style = "float: left; font-weight: bold; font-size: 20px;"),
-                  modalButton("Dismiss"),
+                  actionButton(ns("return"), "Return", class = "btn-sm"),
+                  actionButton(ns("reset"), "Reset", class = "btn-sm"),
                   style = "overflow: hidden; text-align: right;"
                 ),
 
                 HTML(warn_icon_html, glue::glue("There were no closed Milestones found in {org}/{repo}.<br>
-                                             Close relevant Milestones on GitHub to indicate finished QC, then click \"Reset\" in the top right corner of this app.<div style=\"margin-bottom: 9px;\"></div>")),
-                tags$a(href = milestone_list_url, "Click here to close Milestones on GitHub", target = "_blank"),
+                                             It is recommended to close relevant Milestones on GitHub to indicate finished QC.<div style=\"margin-bottom: 9px;\"></div>")),
+                tags$span(
+                  tags$a(href = milestone_list_url, target = "_blank", HTML("Click here to close Milestones on GitHub.")),
+                  "Next, click \"Reset\" to refresh the app."
+                ),
                 easyClose = TRUE,
                 footer = NULL
               )

From 01f0daaafd176f93728236f8157e33995b3eae4a Mon Sep 17 00:00:00 2001
From: Jenna Johnson <jenna@a2-ai.com>
Date: Wed, 30 Oct 2024 14:34:16 +0000
Subject: [PATCH 3/3] updates version and NEWS.md

---
 DESCRIPTION | 2 +-
 NEWS.md     | 5 +++++
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/DESCRIPTION b/DESCRIPTION
index eb10f42..bfa5047 100644
--- a/DESCRIPTION
+++ b/DESCRIPTION
@@ -1,6 +1,6 @@
 Package: ghqc.app
 Title: Create QC Checklists in Github Issues
-Version: 0.1.1
+Version: 0.1.2
 Authors@R: c(
     person("Jenna", "Johnson", email = "jenna@a2-ai.com", role = c("aut", "cre")),
     person("Anne", "Zheng", email = "anne@a2-ai.com", role = c("aut")),
diff --git a/NEWS.md b/NEWS.md
index 88624c9..33a8f11 100644
--- a/NEWS.md
+++ b/NEWS.md
@@ -1,6 +1,11 @@
 
 # ghqc.app (beta version)
 
+# ghqc.app 0.1.2
+
+- Fixes bug in record app warning modal pop-up for unclosed milestones/issues/checklist items: Milestone link wasn't clickable
+- Improves "No closed milestones" modal pop-up warning in record app. Language change to "It is recommended to close milestones" and adds a reset link to modal for users to click after closing milestones.
+
 # ghqc.app 0.1.1
 
 # Minor bug fixes