From a5790166ed5f06f29ec5e1afe902e5287829162f Mon Sep 17 00:00:00 2001 From: Matt Smith Date: Tue, 19 Nov 2024 15:08:48 +0000 Subject: [PATCH] fixed bug in add_table_footnotes.py updated notes_text to True instead of notes_added, this caused the addition of notes to break. --- DESCRIPTION | 4 ++-- inst/scripts/add_table_footnotes.py | 2 +- man/reportifyr.Rd | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/DESCRIPTION b/DESCRIPTION index 3b50f56..e7cdb2e 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -1,6 +1,6 @@ Package: reportifyr Title: Create reproducible reports with quarto and word -Version: 0.2.4 +Version: 0.2.5 Authors@R: c( person("Jacob", "Dumbleton", , "jacob@a2-ai.com", role = c("aut", "cre")), person("Matthew", "Smith", , "matthews@a2-ai.com", role = "aut"), @@ -10,7 +10,7 @@ Authors@R: c( person("Agnes", "Kim", , "agnes@a2-ai.com", role = "aut"), person("Anne", "Zheng", , "anne@a2-ai.com", role = "aut"), person("Jenna", "Johnson", , "jenna@a2-ai.com", role = "aut"), - person("Fernando", "Carreno", , "fernando.o.carreno@gsk.com", role = "ctb"), + person("Fernando", "Carreno", , "fernando.o.carreno@gsk.com", role = "aut"), person("Kashyap", "Patel", , "kashyap.x.patel@gsk.com", role = "ctb"), person("Maxwell", "Chirehwa", , "maxwell.t.chirehwa@gsk.com", role = "ctb"), person("Wesley", "Cummings", , "wes@a2-ai.com", role = "ctb"), diff --git a/inst/scripts/add_table_footnotes.py b/inst/scripts/add_table_footnotes.py index bd1102e..0221367 100644 --- a/inst/scripts/add_table_footnotes.py +++ b/inst/scripts/add_table_footnotes.py @@ -142,7 +142,7 @@ def create_meta_text_lines(footnotes, metadata, include_object_path): notes_text += f". {note}" else: notes_text += f"Notes: {note}" - notes_text = True + notes_added = True if not notes_added: notes_text += "Notes N/A" diff --git a/man/reportifyr.Rd b/man/reportifyr.Rd index 3f5fae4..0d68697 100644 --- a/man/reportifyr.Rd +++ b/man/reportifyr.Rd @@ -113,11 +113,11 @@ Authors: \item Agnes Kim \email{agnes@a2-ai.com} \item Anne Zheng \email{anne@a2-ai.com} \item Jenna Johnson \email{jenna@a2-ai.com} + \item Fernando Carreno \email{fernando.o.carreno@gsk.com} } Other contributors: \itemize{ - \item Fernando Carreno \email{fernando.o.carreno@gsk.com} [contributor] \item Kashyap Patel \email{kashyap.x.patel@gsk.com} [contributor] \item Maxwell Chirehwa \email{maxwell.t.chirehwa@gsk.com} [contributor] \item Wesley Cummings \email{wes@a2-ai.com} [contributor]