Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] enable bookmarks to load while offline #85

Open
ruthrootz opened this issue Aug 14, 2023 · 8 comments
Open

[Feature] enable bookmarks to load while offline #85

ruthrootz opened this issue Aug 14, 2023 · 8 comments
Labels
bug Something isn't working enhancement New feature or request medium priority

Comments

@ruthrootz
Copy link
Member

At least on iOS, bookmarks don't load when offline.

@ruthrootz ruthrootz added the enhancement New feature or request label Aug 14, 2023
@Christoffyw
Copy link
Collaborator

I can't reproduce this issue. Is this happening on the latest production version?

@ruthrootz
Copy link
Member Author

@Christoffyw Looks like it only happens if the app hasn't been opened in a while (a few hours to a day or more?). For example, we have bad reception at our church, so opening the app in church usually results in a blank Bookmarks page unless the user had the app open before coming to church.

@ruthrootz
Copy link
Member Author

I can't reproduce this issue. Is this happening on the latest production version?

Yes, 2.0.2

@Nomalah
Copy link
Member

Nomalah commented Aug 14, 2023

@Nomalah I'm hesitant to get rid of my Hungarian and Zbirka bookmarks to test your theory 😆 But that sounds very plausible.

@Nomalah Nomalah added bug Something isn't working medium priority labels Aug 14, 2023
@Nomalah
Copy link
Member

Nomalah commented Aug 14, 2023

This also might be inadvertently fixed when I fix #65, I'm reworking the remote books a bit, and I have a guess that it might end up fixing this.

@Nomalah
Copy link
Member

Nomalah commented Aug 14, 2023

I'll turn off my data and test that way, we'll see if we can reproduce over here. Of note, is that the current production version caches the metadata for books and songs for an hour, so that's likely what you're seeing.

Looks like it only happens if the app hasn't been opened in a while (a few hours to a day or more?)

@Nomalah
Copy link
Member

Nomalah commented Aug 14, 2023

My testing shows that add-on books without a connection results in missing bookmarks (instead of unavailable or similar)

@ruthrootz
Copy link
Member Author

Hmmm. Here's what it looks like for me...

When I open the app with airplane mode on (after a few hours of the app being closed):
image
image

Reopening the app with cellular/wifi connected:
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request medium priority
Projects
None yet
Development

No branches or pull requests

3 participants