Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to add direct MIDI-opening support for OSX #284

Merged
merged 23 commits into from
Sep 23, 2024
Merged

Attempt to add direct MIDI-opening support for OSX #284

merged 23 commits into from
Sep 23, 2024

Conversation

dylwhich
Copy link
Collaborator

@dylwhich dylwhich commented Sep 18, 2024 •
edited
Loading

Description

Test Instructions

Ticket Links

Readiness Checklist

  • I have run make format to format the changes
  • I have compiled the firmware and the changes have no warnings
  • I have compiled the emulator and the changes have no warnings
  • I have run make cppcheck and checked that cppcheck_result.txt has no warnings for the changes
  • I have added doxygen comments to any code used by more than one Swadge mode. This includes /*! \file comments with Design Philosophy, Usage, and Example sections for new headers.
  • I have run make docs and checked that doxy_warnings.txt has no warnings for the new code

@dylwhich
Copy link
Collaborator Author

dylwhich commented Sep 18, 2024 •
edited
Loading

This python hack seems to be the only full-fledged example of doing this with actual C code that does this on the internet:
pyinstaller/pyinstaller#1309
https://github.com/pyinstaller/pyinstaller/pull/50/files

Edit:
This, of course, no longer works at all on 64-bit OSX. Here's the replacement: https://github.com/dhyams/pyinstaller/blob/develop/bootloader/src/pyi_utils.c which... is mostly commented out and might not actually do anything?

@AEFeinstein
Copy link
Owner

This seems like such a pain,

@dylwhich
Copy link
Collaborator Author

This seems like such a pain,

It really is... why can't macs be normal!? Apparently it is actually possible to get a mac VM without giving apple any money: https://github.com/foxlet/macOS-Simple-KVM so I'm trying that now and hoping this gets a lot easier when I can actually try things locally...

@dylwhich dylwhich marked this pull request as ready for review September 22, 2024 22:50
@AEFeinstein AEFeinstein merged commit 45147c2 into main Sep 23, 2024
6 checks passed
@AEFeinstein AEFeinstein deleted the open-files-osx branch September 23, 2024 01:33
DebrisHauler added a commit that referenced this pull request Sep 23, 2024
@DebrisHauler
Squashed commit of the following:
38709d2 
commit bec7451
Author: gelakinetic <[email protected]>
Date:   Sun Sep 22 21:44:55 2024 -0400

    Add Initial Swadge Hero (#297)

    Add hardware type config

    Fix or suppress warnings

commit 45147c2
Author: Dylan Whichard <[email protected]>
Date:   Sun Sep 22 18:33:53 2024 -0700

    Add direct MIDI-opening support for OSX (#284)

commit 6695116
Author: gelakinetic <[email protected]>
Date:   Sun Sep 22 14:15:53 2024 -0400

    Sokobokobanaban first merge (#296)

commit 0e137f6
Author: JVeg199X <[email protected]>
Date:   Sun Sep 22 07:29:50 2024 -0400

    Pango (initial pull request) (#295)

commit 1da5644
Author: Dylan Whichard <[email protected]>
Date:   Sun Sep 22 03:58:48 2024 -0700

    MIDI Registered/Non-registered Parameter Support, default instrument changes (#293)

    Add documentation too

commit 576902a
Author: Dylan Whichard <[email protected]>
Date:   Sun Sep 22 03:52:55 2024 -0700

    Add FreeDesktop config files for native support in graphical desktop environments (#294)

commit 2298b2b
Author: johnnywycliffe <[email protected]>
Date:   Sun Sep 22 06:43:26 2024 -0400

    Palette wsg (#292)

    Add ability to palette-swap WSGs when drawing

commit e6fde30
Author: Dylan Whichard <[email protected]>
Date:   Sat Sep 21 01:15:52 2024 -0700

    Fix broken markdown (#291)

commit 8e3ef72
Author: Dylan Whichard <[email protected]>
Date:   Fri Sep 20 17:17:22 2024 -0700

    Add MIDI technical documentation (#289)

commit 674cb11
Author: cnlohr <[email protected]>
Date:   Thu Sep 19 15:48:56 2024 -0700

    Update demo code for usb hid demo (#287)

commit 69615ad
Author: gelakinetic <[email protected]>
Date:   Thu Sep 19 06:29:38 2024 -0400

    Add pinball to the attic

    But get a few nice things along the way

commit 9c9db12
Author: johnnywycliffe <[email protected]>
Date:   Thu Sep 19 06:00:36 2024 -0400

    Add 2048 to main (#285)

commit 1a16767
Author: Dylan Whichard <[email protected]>
Date:   Wed Sep 18 02:41:54 2024 -0700

    Emulator MIDI File Opening (#283)

    Emulator can now play MIDI files from a computer directly

    * Add emulator utility to inject fake NVS data
    * Add emulator utility to inject fake CNFS data
    * Add --midi-file argument to emulator
    * Add MIDI file docs to EMULATOR.md
dylwhich added a commit that referenced this pull request Sep 24, 2024
@dylwhich
Add direct MIDI-opening support for OSX (#284)
fd0e468
AEFeinstein added a commit that referenced this pull request Sep 27, 2024
@AEFeinstein
Squashed commit of the following:
e2a4089 
commit 426906c
Author: gelakinetic <[email protected]>
Date:   Thu Sep 26 22:38:01 2024 +0000

    Fix HARDWARE_HOTDOG config

commit bec7451
Author: gelakinetic <[email protected]>
Date:   Sun Sep 22 21:44:55 2024 -0400

    Add Initial Swadge Hero (#297)

    Add hardware type config

    Fix or suppress warnings

commit 45147c2
Author: Dylan Whichard <[email protected]>
Date:   Sun Sep 22 18:33:53 2024 -0700

    Add direct MIDI-opening support for OSX (#284)
DebrisHauler added a commit that referenced this pull request Sep 28, 2024
@DebrisHauler
Squashed commit of the following:
a03b405 
commit 426906c
Author: gelakinetic <[email protected]>
Date:   Thu Sep 26 22:38:01 2024 +0000

    Fix HARDWARE_HOTDOG config

commit bec7451
Author: gelakinetic <[email protected]>
Date:   Sun Sep 22 21:44:55 2024 -0400

    Add Initial Swadge Hero (#297)

    Add hardware type config

    Fix or suppress warnings

commit 45147c2
Author: Dylan Whichard <[email protected]>
Date:   Sun Sep 22 18:33:53 2024 -0700

    Add direct MIDI-opening support for OSX (#284)

commit 6695116
Author: gelakinetic <[email protected]>
Date:   Sun Sep 22 14:15:53 2024 -0400

    Sokobokobanaban first merge (#296)

commit 0e137f6
Author: JVeg199X <[email protected]>
Date:   Sun Sep 22 07:29:50 2024 -0400

    Pango (initial pull request) (#295)

commit 1da5644
Author: Dylan Whichard <[email protected]>
Date:   Sun Sep 22 03:58:48 2024 -0700

    MIDI Registered/Non-registered Parameter Support, default instrument changes (#293)

    Add documentation too

commit 576902a
Author: Dylan Whichard <[email protected]>
Date:   Sun Sep 22 03:52:55 2024 -0700

    Add FreeDesktop config files for native support in graphical desktop environments (#294)

commit 2298b2b
Author: johnnywycliffe <[email protected]>
Date:   Sun Sep 22 06:43:26 2024 -0400

    Palette wsg (#292)

    Add ability to palette-swap WSGs when drawing

commit e6fde30
Author: Dylan Whichard <[email protected]>
Date:   Sat Sep 21 01:15:52 2024 -0700

    Fix broken markdown (#291)

commit 8e3ef72
Author: Dylan Whichard <[email protected]>
Date:   Fri Sep 20 17:17:22 2024 -0700

    Add MIDI technical documentation (#289)

commit 674cb11
Author: cnlohr <[email protected]>
Date:   Thu Sep 19 15:48:56 2024 -0700

    Update demo code for usb hid demo (#287)

commit 69615ad
Author: gelakinetic <[email protected]>
Date:   Thu Sep 19 06:29:38 2024 -0400

    Add pinball to the attic

    But get a few nice things along the way

commit 9c9db12
Author: johnnywycliffe <[email protected]>
Date:   Thu Sep 19 06:00:36 2024 -0400

    Add 2048 to main (#285)

commit 1a16767
Author: Dylan Whichard <[email protected]>
Date:   Wed Sep 18 02:41:54 2024 -0700

    Emulator MIDI File Opening (#283)

    Emulator can now play MIDI files from a computer directly

    * Add emulator utility to inject fake NVS data
    * Add emulator utility to inject fake CNFS data
    * Add --midi-file argument to emulator
    * Add MIDI file docs to EMULATOR.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AEFeinstein AEFeinstein AEFeinstein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dylwhich @AEFeinstein