Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uttt pass and play #334

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Uttt pass and play #334

merged 2 commits into from
Dec 2, 2024

Conversation

AEFeinstein
Copy link
Owner

Description

Add pass-and-play to UTTT

Test Instructions

  • Play a pass-and-play game, make sure the victory screen is correct
  • Play a wireless game
  • Play a CPU game

Ticket Links

#328

Readiness Checklist

  • I have run make format to format the changes
  • I have compiled the firmware and the changes have no warnings
  • I have compiled the emulator and the changes have no warnings
  • I have run make cppcheck and checked that cppcheck_result.txt has no warnings for the changes
  • I have added doxygen comments to any code used by more than one Swadge mode. This includes /*! \file comments with Design Philosophy, Usage, and Example sections for new headers.
  • I have run make docs and checked that doxy_warnings.txt has no warnings for the new code

@AEFeinstein
Copy link
Owner Author

@dylwhich do you care to review how i shoehorned in pass-and-play? It's fine if not.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Square was too identical to the cursor...

Copy link
Collaborator

@dylwhich dylwhich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! It's no more shoehorned than the single player AI was

@AEFeinstein AEFeinstein merged commit 36b5b6f into main Dec 2, 2024
6 checks passed
@AEFeinstein AEFeinstein deleted the uttt-pass-and-play branch December 2, 2024 15:09
AEFeinstein added a commit that referenced this pull request Dec 5, 2024
#328 Add UTTT pass-and-play
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants