Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image_set to topostats argparse #1057

Closed
ns-rse opened this issue Dec 17, 2024 · 1 comment
Closed

Add image_set to topostats argparse #1057

ns-rse opened this issue Dec 17, 2024 · 1 comment

Comments

@ns-rse
Copy link
Collaborator

ns-rse commented Dec 17, 2024

In reviewing #1056 I noticed that we do not have a command line option to modify the value of the image_set option.

This should be added as part of the work undertaken by #517 but is small and should probably be squeezed in as I
imagine it would be quite convenient to be able to toggle that option without creating a configuration file and
modifying the value.

ns-rse added a commit that referenced this issue Dec 17, 2024
Closes #1057

In reviewing #1056 I wanted to look at the individual grain curvature plots that were generated and realised that there
was no command-line option to modify the configuration value loaded from the YAML (`topostats/default_config.yaml` or
user specified with `--config-file/-c`).

This means that currently if people want the `all` image set then they have to use `topostats create-config` to create a
configuration file, modify the value of `image_set` and run the analysis with `topostats -c new_config.yaml`.

It was very quick and easy to add this option so I could check the output and as its been done I felt it should be
incorporated into TopoStats.
@ns-rse
Copy link
Collaborator Author

ns-rse commented Dec 18, 2024

Closed by #1058

@ns-rse ns-rse closed this as completed Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant