Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken tests in Better Tracing & Skeletonisation Merger branch #850

Closed
1 of 6 tasks
Tracked by #800
ns-rse opened this issue Jun 4, 2024 · 2 comments
Closed
1 of 6 tasks
Tracked by #800

Fix broken tests in Better Tracing & Skeletonisation Merger branch #850

ns-rse opened this issue Jun 4, 2024 · 2 comments

Comments

@ns-rse
Copy link
Collaborator

ns-rse commented Jun 4, 2024 •
edited
Loading

Whilst working on writing unit tests for maxgamill-sheffield/800-better-tracing which addresses #800 I found that the tests suite does not complete as there are a number of breaking changes.

In total there are 61 tests fail, output with basic details are below...

ERROR tests/test_plotting.py::test_plot_violin - KeyError: "The following id_vars or value_vars are not present in the DataFrame: ['grain_number']"
ERROR tests/test_plotting.py::test_set_label[grain_curvature1-Smaller Curvature] - KeyError: "The following id_vars or value_vars are not present in the DataFrame: ['grain_number']"
ERROR tests/test_plotting.py::test_plot_violin_multiple_directories - KeyError: "The following id_vars or value_vars are not present in the DataFrame: ['grain_number']"
ERROR tests/test_plotting.py::test_set_label_keyerror - KeyError: "The following id_vars or value_vars are not present in the DataFrame: ['grain_number']"
ERROR tests/test_plotting.py::test_plot_kde - KeyError: "The following id_vars or value_vars are not present in the DataFrame: ['grain_number']"
ERROR tests/test_plotting.py::test_plot_kde_multiple_directories - KeyError: "The following id_vars or value_vars are not present in the DataFrame: ['grain_number']"
ERROR tests/test_plotting.py::test_plot_hist - KeyError: "The following id_vars or value_vars are not present in the DataFrame: ['grain_number']"
ERROR tests/test_plotting.py::test_plot_hist_multiple_directories - KeyError: "The following id_vars or value_vars are not present in the DataFrame: ['grain_number']"
ERROR tests/test_plotting.py::test_plot_hist_kde - KeyError: "The following id_vars or value_vars are not present in the DataFrame: ['grain_number']"
ERROR tests/test_plotting.py::test_plot_hist_kde_multiple_directories - KeyError: "The following id_vars or value_vars are not present in the DataFrame: ['grain_number']"
ERROR tests/tracing/test_dnatracing_single_grain.py::test_get_ordered_trace_heights[dnatrace_linear-118-8.8224769e-10-1.7610771e-09] - TypeError: dnaTrace.__init__() got an unexpected keyword argument 'skeletonisation_method'
ERROR tests/tracing/test_dnatracing_single_grain.py::test_get_ordered_trace_heights[dnatrace_circular-151-2.5852866e-09-2.5852866e-09] - TypeError: dnaTrace.__init__() got an unexpected keyword argument 'skeletonisation_method'
ERROR tests/tracing/test_dnatracing_single_grain.py::test_gaussian_filter[dnatrace_linear-5.517763534147536e-06] - TypeError: dnaTrace.__init__() got an unexpected keyword argument 'skeletonisation_method'
ERROR tests/tracing/test_dnatracing_single_grain.py::test_ordered_get_trace_cumulative_distances[linear] - TypeError: dnaTrace.__init__() got an unexpected keyword argument 'skeletonisation_method'
ERROR tests/tracing/test_dnatracing_single_grain.py::test_get_disordered_trace[dnatrace_linear-thin-187-start6-end6] - TypeError: dnaTrace.__init__() got an unexpected keyword argument 'skeletonisation_method'
ERROR tests/tracing/test_dnatracing_single_grain.py::test_gaussian_filter[dnatrace_circular-6.126947266262167e-06] - TypeError: dnaTrace.__init__() got an unexpected keyword argument 'skeletonisation_method'
ERROR tests/tracing/test_dnatracing_single_grain.py::test_ordered_get_trace_cumulative_distances[circular] - TypeError: dnaTrace.__init__() got an unexpected keyword argument 'skeletonisation_method'
ERROR tests/tracing/test_dnatracing_single_grain.py::test_get_disordered_trace[dnatrace_circular-thin-190-start7-end7] - TypeError: dnaTrace.__init__() got an unexpected keyword argument 'skeletonisation_method'
ERROR tests/tracing/test_dnatracing_single_grain.py::test_get_disordered_trace[dnatrace_linear-topostats-120-start0-end0] - TypeError: dnaTrace.__init__() got an unexpected keyword argument 'skeletonisation_method'
ERROR tests/tracing/test_dnatracing_single_grain.py::test_linear_or_circular[dnatrace_circular-True] - TypeError: dnaTrace.__init__() got an unexpected keyword argument 'skeletonisation_method'
ERROR tests/tracing/test_dnatracing_single_grain.py::test_get_fitted_traces[dnatrace_linear-118-start0-end0] - TypeError: dnaTrace.__init__() got an unexpected keyword argument 'skeletonisation_method'
ERROR tests/tracing/test_dnatracing_single_grain.py::test_measure_contour_length[dnatrace_linear-9.040267985905398e-08] - TypeError: dnaTrace.__init__() got an unexpected keyword argument 'skeletonisation_method'
ERROR tests/tracing/test_dnatracing_single_grain.py::test_get_disordered_trace[dnatrace_circular-topostats-150-start1-end1] - TypeError: dnaTrace.__init__() got an unexpected keyword argument 'skeletonisation_method'
ERROR tests/tracing/test_dnatracing_single_grain.py::test_get_ordered_traces[dnatrace_linear-118-start0-end0] - TypeError: dnaTrace.__init__() got an unexpected keyword argument 'skeletonisation_method'
ERROR tests/tracing/test_dnatracing_single_grain.py::test_measure_contour_length[dnatrace_circular-7.617314045334366e-08] - TypeError: dnaTrace.__init__() got an unexpected keyword argument 'skeletonisation_method'
ERROR tests/tracing/test_dnatracing_single_grain.py::test_get_disordered_trace[dnatrace_linear-zhang-170-start2-end2] - TypeError: dnaTrace.__init__() got an unexpected keyword argument 'skeletonisation_method'
ERROR tests/tracing/test_dnatracing_single_grain.py::test_get_fitted_traces[dnatrace_circular-151-start1-end1] - TypeError: dnaTrace.__init__() got an unexpected keyword argument 'skeletonisation_method'
ERROR tests/tracing/test_dnatracing_single_grain.py::test_get_ordered_traces[dnatrace_circular-151-start1-end1] - TypeError: dnaTrace.__init__() got an unexpected keyword argument 'skeletonisation_method'
ERROR tests/tracing/test_dnatracing_single_grain.py::test_measure_end_to_end_distance[dnatrace_linear-0] - TypeError: dnaTrace.__init__() got an unexpected keyword argument 'skeletonisation_method'
ERROR tests/tracing/test_dnatracing_single_grain.py::test_get_disordered_trace[dnatrace_circular-zhang-184-start3-end3] - TypeError: dnaTrace.__init__() got an unexpected keyword argument 'skeletonisation_method'
ERROR tests/tracing/test_dnatracing_single_grain.py::test_get_splined_traces[dnatrace_linear-1652-start0-end0] - TypeError: dnaTrace.__init__() got an unexpected keyword argument 'skeletonisation_method'
ERROR tests/tracing/test_dnatracing_single_grain.py::test_measure_end_to_end_distance[dnatrace_circular-0] - TypeError: dnaTrace.__init__() got an unexpected keyword argument 'skeletonisation_method'
ERROR tests/tracing/test_dnatracing_single_grain.py::test_get_splined_traces[dnatrace_circular-2114-start1-end1] - TypeError: dnaTrace.__init__() got an unexpected keyword argument 'skeletonisation_method'
ERROR tests/tracing/test_dnatracing_single_grain.py::test_get_disordered_trace[dnatrace_linear-lee-130-start4-end4] - TypeError: dnaTrace.__init__() got an unexpected keyword argument 'skeletonisation_method'
ERROR tests/tracing/test_dnatracing_single_grain.py::test_get_disordered_trace[dnatrace_circular-lee-177-start5-end5] - TypeError: dnaTrace.__init__() got an unexpected keyword argument 'skeletonisation_method'
ERROR tests/test_plotting.py::test_df_from_csv - KeyError: "The following id_vars or value_vars are not present in the DataFrame: ['grain_number']"
ERROR tests/test_plotting.py::test_toposum_class - KeyError: "The following id_vars or value_vars are not present in the DataFrame: ['grain_number']"
ERROR tests/test_plotting.py::test_outfile - KeyError: "The following id_vars or value_vars are not present in the DataFrame: ['grain_number']"
ERROR tests/test_plotting.py::test_set_label[contour_length-Contour Length] - KeyError: "The following id_vars or value_vars are not present in the DataFrame: ['grain_number']"
ERROR tests/test_plotting.py::test_set_label[end_to_end_distance-End to End Distance] - KeyError: "The following id_vars or value_vars are not present in the DataFrame: ['grain_number']"
ERROR tests/test_plotting.py::test_set_label[grain_bound_len-Circumference] - KeyError: "The following id_vars or value_vars are not present in the DataFrame: ['grain_number']"
FAILED tests/test_plotting.py::test_toposum - KeyError: "The following id_vars or value_vars are not present in the DataFrame: ['grain_number']"
FAILED tests/test_grainstats_minicircle.py::test_grainstats_regression
FAILED tests/test_plottingfuncs.py::test_plot_and_save_non_square_bounding_box - Failed: Error: Image files did not match.
FAILED tests/test_grainstats_minicircle.py::test_cropped_image - assert (1, 1) == (21, 21)
FAILED tests/tracing/test_dnatracing_methods.py::test_linear_or_circular[grain1-False] - AttributeError: 'dnaTrace' object has no attribute 'mol_is_circular'. Did you mean: 'mol_is_circulars'?
FAILED tests/tracing/test_dnatracing_methods.py::test_linear_or_circular[grain2-True] - AttributeError: 'dnaTrace' object has no attribute 'mol_is_circular'. Did you mean: 'mol_is_circulars'?
FAILED tests/tracing/test_dnatracing_methods.py::test_linear_or_circular[grain7-False] - AttributeError: 'dnaTrace' object has no attribute 'mol_is_circular'. Did you mean: 'mol_is_circulars'?
FAILED tests/tracing/test_dnatracing_methods.py::test_linear_or_circular[grain0-False] - AttributeError: 'dnaTrace' object has no attribute 'mol_is_circular'. Did you mean: 'mol_is_circulars'?
FAILED tests/tracing/test_dnatracing_methods.py::test_linear_or_circular[grain3-False] - AttributeError: 'dnaTrace' object has no attribute 'mol_is_circular'. Did you mean: 'mol_is_circulars'?
FAILED tests/tracing/test_dnatracing_methods.py::test_linear_or_circular[grain8-False] - AttributeError: 'dnaTrace' object has no attribute 'mol_is_circular'. Did you mean: 'mol_is_circulars'?
FAILED tests/test_plottingfuncs.py::test_plot_and_save_no_colorbar - Failed: Error: Image files did not match.
FAILED tests/tracing/test_dnatracing_methods.py::test_linear_or_circular[grain13-False] - AttributeError: 'dnaTrace' object has no attribute 'mol_is_circular'. Did you mean: 'mol_is_circulars'?
FAILED tests/tracing/test_dnatracing_methods.py::test_linear_or_circular[grain9-True] - AttributeError: 'dnaTrace' object has no attribute 'mol_is_circular'. Did you mean: 'mol_is_circulars'?
FAILED tests/tracing/test_dnatracing_methods.py::test_linear_or_circular[grain4-False] - AttributeError: 'dnaTrace' object has no attribute 'mol_is_circular'. Did you mean: 'mol_is_circulars'?
FAILED tests/tracing/test_dnatracing_methods.py::test_linear_or_circular[grain14-False] - AttributeError: 'dnaTrace' object has no attribute 'mol_is_circular'. Did you mean: 'mol_is_circulars'?
FAILED tests/tracing/test_dnatracing_methods.py::test_linear_or_circular[grain10-False] - AttributeError: 'dnaTrace' object has no attribute 'mol_is_circular'. Did you mean: 'mol_is_circulars'?
FAILED tests/tracing/test_dnatracing_methods.py::test_linear_or_circular[grain5-True] - AttributeError: 'dnaTrace' object has no attribute 'mol_is_circular'. Did you mean: 'mol_is_circulars'?
FAILED tests/tracing/test_dnatracing_methods.py::test_linear_or_circular[grain11-False] - AttributeError: 'dnaTrace' object has no attribute 'mol_is_circular'. Did you mean: 'mol_is_circulars'?
FAILED tests/tracing/test_dnatracing_methods.py::test_get_splined_traces[trace_image0-1.0-True-0.0-expected_spline_image0] - AttributeError: type object 'genTracingFuncs' has no attribute 'countNeighbours'
FAILED tests/tracing/test_dnatracing_multigrain.py::test_trace_image[multigrain_lee-lee-1-statistics2-ordered_trace_start2-ordered_trace_end2] - TypeError: trace_image() got an unexpected keyword argument 'skeletonisation_method'
FAILED tests/tracing/test_dnatracing_methods.py::test_get_splined_traces[trace_image3-10.0-True-5.0-expected_spline_image3] - AttributeError: type object 'genTracingFuncs' has no attribute 'countNeighbours'
FAILED tests/tracing/test_dnatracing_multigrain.py::test_trace_image[multigrain_topostats-topostats-1-statistics0-ordered_trace_start0-ordered_trace_end0] - TypeError: trace_image() got an unexpected keyword argument 'skeletonisation_method'
FAILED tests/test_plottingfuncs.py::test_mask_cmap - Failed: Error: Image files did not match.
FAILED tests/tracing/test_dnatracing_methods.py::test_linear_or_circular[grain6-True] - AttributeError: 'dnaTrace' object has no attribute 'mol_is_circular'. Did you mean: 'mol_is_circulars'?
FAILED tests/tracing/test_dnatracing_methods.py::test_linear_or_circular[grain12-True] - AttributeError: 'dnaTrace' object has no attribute 'mol_is_circular'. Did you mean: 'mol_is_circulars'?
FAILED tests/tracing/test_dnatracing_multigrain.py::test_trace_image[multigrain_thin-thin-1-statistics3-ordered_trace_start3-ordered_trace_end3] - TypeError: trace_image() got an unexpected keyword argument 'skeletonisation_method'
FAILED tests/tracing/test_dnatracing_multigrain.py::test_trace_image[multigrain_zhang-zhang-1-statistics1-ordered_trace_start1-ordered_trace_end1] - TypeError: trace_image() got an unexpected keyword argument 'skeletonisation_method'
FAILED tests/tracing/test_dnatracing_methods.py::test_get_splined_traces[trace_image1-1.0-True-10.0-expected_spline_image1] - AttributeError: type object 'genTracingFuncs' has no attribute 'countNeighbours'
FAILED tests/tracing/test_dnatracing_multigrain.py::test_prep_arrays[0-target_image0-target_mask0] - ValueError: too many values to unpack (expected 2)
FAILED tests/tracing/test_dnatracing_methods.py::test_get_splined_traces[trace_image4-5.0-False-5.0-expected_spline_image4] - AttributeError: type object 'genTracingFuncs' has no attribute 'countNeighbours'
FAILED tests/tracing/test_dnatracing_multigrain.py::test_prep_arrays[1-target_image1-target_mask1] - ValueError: too many values to unpack (expected 2)
FAILED tests/tracing/test_dnatracing_multigrain.py::test_image_trace_unequal_arrays - TypeError: trace_image() got an unexpected keyword argument 'skeletonisation_method'
FAILED tests/tracing/test_dnatracing_methods.py::test_get_splined_traces[trace_image2-10.0-True-0.0-expected_spline_image2] - AttributeError: type object 'genTracingFuncs' has no attribute 'countNeighbours'
FAILED tests/tracing/test_dnatracing_methods.py::test_get_splined_traces[trace_image5-4.0-False-5.0-expected_spline_image5] - AttributeError: type object 'genTracingFuncs' has no attribute 'countNeighbours'
FAILED tests/tracing/test_dnatracing_single_grain.py::test_trace_grain[cropped_image0-cropped_mask0-linear_test_topostats-topostats-3.115753758716346e-08-False-5.684734982126664e-08] - TypeError: trace_grain() got an unexpected keyword argument 'skeletonisation_method'
FAILED tests/tracing/test_dnatracing_methods.py::test_get_splined_traces[trace_image6-5.0-False-0.0-expected_spline_image6] - AttributeError: type object 'genTracingFuncs' has no attribute 'countNeighbours'
FAILED tests/tracing/test_dnatracing_single_grain.py::test_trace_grain[cropped_image1-cropped_mask1-circular_test_topostats-topostats-0-True-7.617314045334366e-08] - TypeError: trace_grain() got an unexpected keyword argument 'skeletonisation_method'
FAILED tests/tracing/test_dnatracing_single_grain.py::test_trace_grain[cropped_image2-cropped_mask2-linear_test_zhang-zhang-2.6964685842539566e-08-False-6.194694383968303e-08] - TypeError: trace_grain() got an unexpected keyword argument 'skeletonisation_method'
FAILED tests/tracing/test_dnatracing_single_grain.py::test_trace_grain[cropped_image4-cropped_mask4-linear_test_lee-lee-3.197879765453915e-08-False-5.655032001817721e-08] - TypeError: trace_grain() got an unexpected keyword argument 'skeletonisation_method'
FAILED tests/tracing/test_dnatracing_single_grain.py::test_trace_grain[cropped_image3-cropped_mask3-circular_test_zhang-zhang-9.636691058914389e-09-False-8.187508931608563e-08] - TypeError: trace_grain() got an unexpected keyword argument 'skeletonisation_method'
FAILED tests/tracing/test_dnatracing_methods.py::test_get_splined_traces[trace_image7-5.0-False-5.0-expected_spline_image7] - AttributeError: type object 'genTracingFuncs' has no attribute 'countNeighbours'
FAILED tests/tracing/test_dnatracing_single_grain.py::test_trace_grain[cropped_image5-cropped_mask5-circular_test_lee-lee-8.261640682714017e-09-False-8.062559919860788e-08] - TypeError: trace_grain() got an unexpected keyword argument 'skeletonisation_method'
FAILED tests/tracing/test_dnatracing_single_grain.py::test_trace_grain[cropped_image6-cropped_mask6-linear_test_thin-thin-4.068855894099921e-08-False-5.518856387362746e-08] - TypeError: trace_grain() got an unexpected keyword argument 'skeletonisation_method'
FAILED tests/tracing/test_pruning.py::TestTopoStatsPrune::test_find_branch_ends[Linear array with two forks at one end]
FAILED tests/tracing/test_dnatracing_single_grain.py::test_trace_grain[cropped_image7-cropped_mask7-circular_test_thin-thin-3.638262839374549e-08-False-3.6512544238919716e-08] - TypeError: trace_grain() got an unexpected keyword argument 'skeletonisation_method'
FAILED tests/tracing/test_pruning.py::TestTopoStatsPruneMethods::test_prune_skeleton[Pruning by length disabled and leaves branch, height threshold decreased] - AttributeError: 'heightPruning' object has no attribute 'astype'
FAILED tests/tracing/test_pruning.py::TestHeightPruningBasic::test_remove_bridges[ring with branches] - AssertionError: 
FAILED tests/test_plottingfuncs.py::test_plot_and_save_colorbar_and_axes - Failed: Error: Image files did not match.
FAILED tests/test_plottingfuncs.py::test_plot_and_save_no_axes - Failed: Error: Image files did not match.
FAILED tests/test_plottingfuncs.py::test_plot_and_save_no_axes_no_colorbar - Failed: Error: Image files did not match.
FAILED tests/test_plottingfuncs.py::test_high_dpi - Failed: Error: Image files did not match.
FAILED tests/test_plottingfuncs.py::test_mask_dilation - Failed: Error: Image files did not match.
FAILED tests/test_plotting.py::test_melt_data - KeyError: "The following id_vars or value_vars are not present in the DataFrame: ['grain_number']"
FAILED tests/test_processing.py::test_process_scan_below - IndexError: list index out of range
FAILED tests/test_processing.py::test_process_stages[Filtering, Grain, GrainStats and DNA Tracing enabled] - KeyError: "'green_black' is not a known colormap name"
FAILED tests/test_processing.py::test_process_scan_no_grains - KeyError: "'green_black' is not a known colormap name"
FAILED tests/test_processing.py::test_process_scan_above - KeyError: "'green_black' is not a known colormap name"
FAILED tests/test_processing.py::test_process_scan_align_grainstats_dnatracing - IndexError: list index out of range
FAILED tests/test_processing.py::test_process_scan_both - KeyError: "'green_black' is not a known colormap name"
FAILED tests/test_processing.py::test_run_dnatracing - TypeError: run_dnatracing() got an unexpected keyword argument 'grain_out_path'
FAILED tests/test_run_topostats.py::test_run_topostats_process_debug
FAILED tests/test_run_topostats.py::test_run_topostats_process_all

Many of these are unexpected keyword argument which suggests one of a few things...

  1. New arguments have been added to the configuration file but the existing methods have not been updated to accept these.
  2. Arguments have changed name.

Common keyword arguments that crop up repeatedly in errors and possible causes/problems and other types of errors are listed below.

  • skeletonisation_method - which is a new argument introduced in this branch but not updated in many test files (by far the most common cause of errors/failures).
  • countNeighbours - looks like an old function of the genTracingFuncs module that has been moved/renamed/removed.
  • AttributeError: 'dnaTrace' object has no attribute 'mol_is_circular'. Did you mean: 'mol_is_circulars'? - looks like a renaming issue where plural is now used, should be easy to correct.
  • KeyError : 'green_black' is not a known colormap name - a new colormap introduced in some manner, probably needs to be defined in topostats/theme.py although it does have a new blu_purp_green colormap included so perhaps what is required is green_black > blu_purp_green (personally I would favor not using abbreviations tab-auto-complete saves typing and full names are easier to remember than abbreviations so blue_purple_green).
  • IndexError - crops up in test_processing.py::test_process_scan_align_grainstats_dnatracing
  • A number of test_plottingfuncs.py do not match the existing images this will need investigating and resolving.
@ns-rse ns-rse mentioned this issue Jun 4, 2024
Closed
30 tasks
This was referenced Sep 24, 2024
Merged
Merged
Merged
Merged
Merged
@ns-rse
Copy link
Collaborator Author

ns-rse commented Sep 24, 2024

Current state of failed tests is shown below (not sure if this is an improvement or not 😆 !).

SKIPPED [1] tests/test_utils.py:674: awaiting test development
SKIPPED [2] tests/tracing/test_dnatracing_single_grain.py:157: Need to correctly prune arrays first.
SKIPPED [2] tests/tracing/test_dnatracing_single_grain.py:178: Need to correctly prune arrays first.
SKIPPED [2] tests/tracing/test_dnatracing_single_grain.py:209: Need to correctly prune arrays first.
SKIPPED [2] tests/tracing/test_dnatracing_single_grain.py:230: Need to correctly prune arrays first.
SKIPPED [2] tests/tracing/test_dnatracing_single_grain.py:306: Need to correctly prune arrays first.
SKIPPED [2] tests/tracing/test_dnatracing_single_grain.py:347: Need to correctly prune arrays first.
SKIPPED [2] tests/tracing/test_dnatracing_single_grain.py:376: Need to correctly prune arrays first.
SKIPPED [4] tests/tracing/test_dnatracing_single_grain.py:254: Need to correctly prune arrays first.
SKIPPED [2] tests/tracing/test_dnatracing_single_grain.py:278: Need to correctly prune arrays first.
SKIPPED [2] tests/tracing/test_pruning.py: two branches at the end does not have 'nibs' removed by the rm_nibs() function, instead a T-shaped junction remains. This is only removed by calling getSkeleton(method='zhang').get_skeleton() which is done under the prune_all_skeletons() method but this method is is to be removed since looping over all skeletons is outside of the scope/remit of the code and handled in process_scan().
SKIPPED [1] tests/tracing/test_pruning.py: unconditional skip
XFAIL tests/tracing/test_pruning.py::test_local_area_sum[3x3 1's; point on top edge] - Point on top edge of image.
XFAIL tests/tracing/test_pruning.py::test_local_area_sum[3x3 non-binary array; point as list] - Array is not binary.
XFAIL tests/tracing/test_pruning.py::test_local_area_sum[3x3 1's; point on left edge] - Point on left edge of image.
XFAIL tests/tracing/test_pruning.py::test_local_area_sum[3x3 1's; point on bottom edge] - Point on bottom edge of image.
XFAIL tests/tracing/test_pruning.py::test_local_area_sum[3x3 1's; point on right edge] - Point on right edge of image.
XFAIL tests/tracing/test_pruning.py::test_local_area_sum[3x3 1's; point on corner] - Point on corner of image.
ERROR tests/tracing/test_dnatracing_single_grain.py::test_gaussian_filter[linear molecule] - KeyError: 'dnatracing'
ERROR tests/tracing/test_dnatracing_single_grain.py::test_get_disordered_trace[linear molecule, skeletonise zhang] - KeyError: 'dnatracing'
ERROR tests/tracing/test_dnatracing_single_grain.py::test_gaussian_filter[circular molecule] - KeyError: 'dnatracing'
ERROR tests/tracing/test_dnatracing_single_grain.py::test_get_disordered_trace[circular molecule, skeletonise zhang] - KeyError: 'dnatracing'
ERROR tests/tracing/test_nodestats.py::test_analyse_nodes - TypeError: nodeStats.__init__() missing 1 required positional argument: 'pair_odd_branches'
ERROR tests/tracing/test_dnatracing_single_grain.py::test_get_disordered_trace[linear molecule, skeletonise topostats] - KeyError: 'dnatracing'
ERROR tests/tracing/test_dnatracing_single_grain.py::test_get_disordered_trace[linear molecule, skeletonise lee] - KeyError: 'dnatracing'
ERROR tests/tracing/test_dnatracing_single_grain.py::test_get_disordered_trace[circular molecule, skeletonise lee] - KeyError: 'dnatracing'
ERROR tests/tracing/test_dnatracing_single_grain.py::test_get_disordered_trace[circular molecule, skeletonise topostats] - KeyError: 'dnatracing'
ERROR tests/tracing/test_dnatracing_single_grain.py::test_get_disordered_trace[linear molecule, skeletonise thin] - KeyError: 'dnatracing'
ERROR tests/tracing/test_dnatracing_single_grain.py::test_get_disordered_trace[circular molecule, skeletonise thin] - KeyError: 'dnatracing'
FAILED tests/test_utils.py::test_udpate_plotting_config_adding_required_options[DPI None in main, extracted channel DPI should stay at 100] - KeyError: 'core_set'
FAILED tests/test_utils.py::test_udpate_plotting_config_adding_required_options[DPI 600 in main, extracted channel DPI should update to 600] - KeyError: 'core_set'
FAILED tests/tracing/test_dnatracing_methods.py::test_linear_or_circular[diagonal2] - AttributeError: 'dnaTrace' object has no attribute 'mol_is_circular'. Did you mean: 'mol_is_circulars'?
FAILED tests/tracing/test_dnatracing_methods.py::test_linear_or_circular[vertical] - AttributeError: 'dnaTrace' object has no attribute 'mol_is_circular'. Did you mean: 'mol_is_circulars'?
FAILED tests/test_utils.py::test_create_empty_dataframe - AssertionError: assert equals failed
FAILED tests/tracing/test_dnatracing_methods.py::test_linear_or_circular[diagonal3] - AttributeError: 'dnaTrace' object has no attribute 'mol_is_circular'. Did you mean: 'mol_is_circulars'?
FAILED tests/tracing/test_dnatracing_methods.py::test_linear_or_circular[horizontal] - AttributeError: 'dnaTrace' object has no attribute 'mol_is_circular'. Did you mean: 'mol_is_circulars'?
FAILED tests/tracing/test_dnatracing_methods.py::test_linear_or_circular[circle] - AttributeError: 'dnaTrace' object has no attribute 'mol_is_circular'. Did you mean: 'mol_is_circulars'?
FAILED tests/tracing/test_dnatracing_methods.py::test_linear_or_circular[diagonal1] - AttributeError: 'dnaTrace' object has no attribute 'mol_is_circular'. Did you mean: 'mol_is_circulars'?
FAILED tests/tracing/test_dnatracing_methods.py::test_get_splined_traces[trace_image0-1.0-True-0.0-expected_spline_image0] - TypeError: dnaTrace.get_splined_traces() missing 2 required positional arguments: 'fitted_trace' and 'mol_is_circular'
FAILED tests/tracing/test_dnatracing_methods.py::test_linear_or_circular[double_L] - AttributeError: 'dnaTrace' object has no attribute 'mol_is_circular'. Did you mean: 'mol_is_circulars'?
FAILED tests/tracing/test_dnatracing_methods.py::test_linear_or_circular[blob] - AttributeError: 'dnaTrace' object has no attribute 'mol_is_circular'. Did you mean: 'mol_is_circulars'?
FAILED tests/tracing/test_dnatracing_methods.py::test_get_splined_traces[trace_image5-4.0-False-5.0-expected_spline_image5] - TypeError: dnaTrace.get_splined_traces() missing 2 required positional arguments: 'fitted_trace' and 'mol_is_circular'
FAILED tests/tracing/test_dnatracing_methods.py::test_get_splined_traces[trace_image1-1.0-True-10.0-expected_spline_image1] - TypeError: dnaTrace.get_splined_traces() missing 2 required positional arguments: 'fitted_trace' and 'mol_is_circular'
FAILED tests/tracing/test_dnatracing_methods.py::test_linear_or_circular[diagonal_end_single_L] - AttributeError: 'dnaTrace' object has no attribute 'mol_is_circular'. Did you mean: 'mol_is_circulars'?
FAILED tests/tracing/test_dnatracing_methods.py::test_linear_or_circular[cross] - AttributeError: 'dnaTrace' object has no attribute 'mol_is_circular'. Did you mean: 'mol_is_circulars'?
FAILED tests/tracing/test_dnatracing_methods.py::test_get_splined_traces[trace_image6-5.0-False-0.0-expected_spline_image6] - TypeError: dnaTrace.get_splined_traces() missing 2 required positional arguments: 'fitted_trace' and 'mol_is_circular'
FAILED tests/tracing/test_dnatracing_methods.py::test_linear_or_circular[diagonal_end_straight] - AttributeError: 'dnaTrace' object has no attribute 'mol_is_circular'. Did you mean: 'mol_is_circulars'?
FAILED tests/tracing/test_dnatracing_methods.py::test_linear_or_circular[singl_L] - AttributeError: 'dnaTrace' object has no attribute 'mol_is_circular'. Did you mean: 'mol_is_circulars'?
FAILED tests/tracing/test_dnatracing_methods.py::test_get_splined_traces[trace_image2-10.0-True-0.0-expected_spline_image2] - TypeError: dnaTrace.get_splined_traces() missing 2 required positional arguments: 'fitted_trace' and 'mol_is_circular'
FAILED tests/tracing/test_dnatracing_methods.py::test_linear_or_circular[figure8] - AttributeError: 'dnaTrace' object has no attribute 'mol_is_circular'. Did you mean: 'mol_is_circulars'?
FAILED tests/tracing/test_dnatracing_methods.py::test_get_splined_traces[trace_image7-5.0-False-5.0-expected_spline_image7] - TypeError: dnaTrace.get_splined_traces() missing 2 required positional arguments: 'fitted_trace' and 'mol_is_circular'
FAILED tests/tracing/test_dnatracing_methods.py::test_get_splined_traces[trace_image3-10.0-True-5.0-expected_spline_image3] - TypeError: dnaTrace.get_splined_traces() missing 2 required positional arguments: 'fitted_trace' and 'mol_is_circular'
FAILED tests/tracing/test_dnatracing_methods.py::test_linear_or_circular[three_ends] - AttributeError: 'dnaTrace' object has no attribute 'mol_is_circular'. Did you mean: 'mol_is_circulars'?
FAILED tests/tracing/test_dnatracing_methods.py::test_get_splined_traces[trace_image4-5.0-False-5.0-expected_spline_image4] - TypeError: dnaTrace.get_splined_traces() missing 2 required positional arguments: 'fitted_trace' and 'mol_is_circular'
FAILED tests/tracing/test_dnatracing_methods.py::test_linear_or_circular[six_ends] - AttributeError: 'dnaTrace' object has no attribute 'mol_is_circular'. Did you mean: 'mol_is_circulars'?
FAILED tests/tracing/test_nodestats.py::test_connect_extended_nodes_nearest[theta_grain] - TypeError: nodeStats.__init__() missing 1 required positional argument: 'pair_odd_branches'
FAILED tests/tracing/test_nodestats.py::test_connect_extended_nodes_nearest[figure_8] - TypeError: nodeStats.__init__() missing 1 required positional argument: 'pair_odd_branches'
FAILED tests/tracing/test_nodestats.py::test_add_branches_to_labelled_image[branch_under_over_order0-catenane_node_0_matched_branches_analyse_node_branches.pkl-catenane_node_0_masked_image.pkl-branch_start_coords0-catenane_node_0_ordered_branches.pkl-pairs0-True-image_shape0-catenane_node_0_branch_image.npy-catenane_node_0_avg_image.npy] - FileNotFoundError: [Errno 2] No such file or directory: '/home/neil/work/git/hub/AFM-SPM/TopoStats/tests/resources/catenane_node_0_branch_image.npy'
FAILED tests/tracing/test_nodestats.py::test_analyse_node_branches[node 0] - FileNotFoundError: [Errno 2] No such file or directory: '/home/neil/work/git/hub/AFM-SPM/TopoStats/tests/resources/catenane_node_0_reduced_node_area.npy'
FAILED tests/test_processing.py::test_process_stages[Only filtering enabled] - AssertionError: assert 'Detection of grains disabled, returning empty data frame.' in 'INFO     topostats:processing.py:858 Processing : minicircle_small\nINFO     topostats:processing.py:78 [minicircle_small] Image dimensions: (64, 64...
FAILED tests/test_processing.py::test_process_scan_align_grainstats_dnatracing - KeyError: 'dnatracing'
FAILED tests/test_processing.py::test_run_grainstats - AssertionError: assert 22 == 21
FAILED tests/test_processing.py::test_process_scan_below
FAILED tests/test_processing.py::test_process_scan_above
FAILED tests/test_processing.py::test_process_scan_both - AssertionError: assert equals failed
FAILED tests/test_run_topostats.py::test_run_topostats_process_debug

This was referenced Oct 1, 2024
Open
Open
@ns-rse
Copy link
Collaborator Author

ns-rse commented Oct 15, 2024

Tests are all passing on maxgamill-sheffield/800-better-tracing.

@ns-rse ns-rse closed this as completed Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ns-rse