Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split ML functionality dependencies into optional-dependencies #916

Open
ns-rse opened this issue Sep 24, 2024 · 1 comment
Open

Split ML functionality dependencies into optional-dependencies #916

ns-rse opened this issue Sep 24, 2024 · 1 comment

Comments

@ns-rse
Copy link
Collaborator

ns-rse commented Sep 24, 2024

TensorFlow is a 600Mb dependency that is now pulled in when installing TopoStats. This can be slow and cumbersome if not on a fast connection (~4 minutes to download on my home connection a supposed 100Mbps connection).

How core is the Tensorflow functionality in the wider community of TopoStats users?

Would it be useful to provide a convenience option of installing without this dependency?

It could be achieved by splitting the dependencies off into their own optional set...

[project.optional-dependencies]
ml = [
  keras,
  tensorflow,
]

And update the documentation to indicate that to get all dependencies for that functionality you should install with pip install topostats[ml].

@ns-rse
Copy link
Collaborator Author

ns-rse commented Nov 27, 2024

This isn't as simple as suggested as it would require moving the point at which the Unet masking models are loaded in the processing.

@ns-rse ns-rse added v2.3.2 and removed v2.3.0 labels Nov 27, 2024
@ns-rse ns-rse removed this from the v2.3.0 milestone Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant