Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update notebooks for better tracing #943

Open
SylviaWhittle opened this issue Oct 11, 2024 · 1 comment
Open

Update notebooks for better tracing #943

SylviaWhittle opened this issue Oct 11, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request v2.3.2

Comments

@SylviaWhittle
Copy link
Collaborator

Is your feature request related to a problem?

#932 Completely breaks the notebooks. They need updating ASAP. I've marked them as outdated so users at least know not to use them yet.

Describe the solution you would like.

Update the notebooks to work on the new topostats structure.

Describe the alternatives you have considered.

No response

Additional context

No response

@SylviaWhittle SylviaWhittle added the enhancement New feature or request label Oct 11, 2024
@SylviaWhittle SylviaWhittle self-assigned this Oct 11, 2024
@ns-rse
Copy link
Collaborator

ns-rse commented Oct 11, 2024

Questions, questions, questions (sorry!)

  • Do we know how widely these notebooks are used both internally and externally?
  • Internally do people use them as a basis for undertaking work?
  • Are all notebooks broken?
  • Is it the YAML configuration that needs updating? If so we should reconsider whether we want to include example configurations for people to copy and paste as that adds an overhead to development to keep the example up-to-date with whatever is in the main branch. We could instead explain how to use topostats create-config.

@ns-rse ns-rse added the v2.3.0 label Nov 19, 2024
@ns-rse ns-rse added this to the v2.3.0 milestone Nov 26, 2024
@ns-rse ns-rse added v2.3.2 and removed v2.3.0 labels Nov 26, 2024
@ns-rse ns-rse removed this from the v2.3.0 milestone Dec 10, 2024
ns-rse added a commit that referenced this issue Dec 16, 2024
One (E712) is a false positive as its used to subset a Pandas DataFrame.

The other two I've no current alternative plan as they involve creating buttons for users to upload files. Not sure
whether these will persist past the notebook refactor (#943) so have disabled the checks for the time being.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v2.3.2
Projects
None yet
Development

No branches or pull requests

2 participants