Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to set image_set for filters, grains and tracing separately to reduce output #958

Open
llwiggins opened this issue Oct 16, 2024 · 4 comments

Comments

@llwiggins
Copy link
Collaborator

Users flagged that the new updates to DNA tracing significantly increase the amount of outputs produced when image_set: all is set in the config file. It was agreed that as all output images have potential to be useful for parameter refining, rather than reduce the output it would be better to have the option to set whether core or all should be output for filters, grains and tracing separately.

@ns-rse
Copy link
Collaborator

ns-rse commented Oct 16, 2024

@llwiggins @SylviaWhittle @MaxGamill-Sheffield @alicepyne

This feels like this is something that needs addressing before merging and making a release, do you agree?

Regardless, what should the defaults be with regards to setting core / all for each stage of filters / grains / tracing ?

@alicepyne
Copy link
Member

alicepyne commented Oct 16, 2024 via email

@SylviaWhittle
Copy link
Collaborator

With how urgent this is to merge (so reviewers can verify the code works) this could be done after a merge I think? It would be preferable to do beforehand aye but I believe the priority currently is that reviewers are able to run the code from main?

@ns-rse
Copy link
Collaborator

ns-rse commented Oct 16, 2024

It will be useful to set some clear Milestones for the coming months work to prioritise the backlog of issues and what needs addressing first (and clear out the existing Milestones!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants