-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to set image_set for filters, grains and tracing separately to reduce output #958
Comments
@llwiggins @SylviaWhittle @MaxGamill-Sheffield @alicepyne This feels like this is something that needs addressing before merging and making a release, do you agree? Regardless, what should the defaults be with regards to setting |
I think defaults to core but would say that separating these can wait until
the next smaller release to avoid scope creep in this one
…On Wed, 16 Oct 2024 at 12:11, Neil Shephard ***@***.***> wrote:
@llwiggins <https://github.com/llwiggins> @SylviaWhittle
<https://github.com/SylviaWhittle> @MaxGamill-Sheffield
<https://github.com/MaxGamill-Sheffield> @alicepyne
<https://github.com/alicepyne>
This feels like this is something that needs addressing *before* merging
and making a release, do you agree?
Regardless, what should the defaults be with regards to setting core / all
for each stage of filters / grains / tracing ?
—
Reply to this email directly, view it on GitHub
<#958 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADJSFMKLJDTBETOF2IGB2LLZ3ZCXBAVCNFSM6AAAAABQA6LXHKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJWGQ4TKNRYGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
With how urgent this is to merge (so reviewers can verify the code works) this could be done after a merge I think? It would be preferable to do beforehand aye but I believe the priority currently is that reviewers are able to run the code from main? |
It will be useful to set some clear Milestones for the coming months work to prioritise the backlog of issues and what needs addressing first (and clear out the existing Milestones!). |
Users flagged that the new updates to DNA tracing significantly increase the amount of outputs produced when
image_set: all
is set in the config file. It was agreed that as all output images have potential to be useful for parameter refining, rather than reduce the output it would be better to have the option to set whethercore
orall
should be output for filters, grains and tracing separately.The text was updated successfully, but these errors were encountered: