Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Summary plots are broken #975

Closed
ns-rse opened this issue Oct 21, 2024 · 0 comments · Fixed by #976
Closed

Summary plots are broken #975

ns-rse opened this issue Oct 21, 2024 · 0 comments · Fixed by #976
Labels
tests Issues pertaining to testing

Comments

@ns-rse
Copy link
Collaborator

ns-rse commented Oct 21, 2024

Whilst working through parametrising the changes proposed in #937 to tests/test_utils.py::test_create_empty_dataframe() I noticed that the renaming of columns in the dataframes has also broken the summary plots that are, by default automatically generated as the log includes the following messages...

EDIT : Only two variables are not present under their old names.

INFO     topostats:plotting.py:409 [plotting] Statistic is not in dataframe : contour_length
INFO     topostats:plotting.py:409 [plotting] Statistic is not in dataframe : end_to_end_distance

This is mostly down to renaming of variables in the grainstats_df or results_df data frame.

This needs fixing and ideally we should put tests in place to ensure that these plots are generated correctly so that future changes are captured and do not rely on serendipity to be caught.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Issues pertaining to testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant