timelineview now shows the name and groups - better overview, if you … #340
Conversation
…have many crons with groups
|
better timeline-overview |
|
Name and Group are only shown if it set in Job-Configuration. |
…dmann/Aoe_Scheduler into feature/name-and-groups-in-timeline
.idea/vcs.xml
Outdated
| @@ -0,0 +1,6 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <project version="4"> | |||
There was a problem hiding this comment.
hi - I just remove the dotfile. Sorry :-)
| * | ||
| * @return array | ||
| */ | ||
| public function getAvailableJobCodes() | ||
| public function getAvailableJobs() |
There was a problem hiding this comment.
lets be non breaking by keeping the old method.
| @@ -55,6 +53,15 @@ public function getName() | |||
| return $name; | |||
| } | |||
|
|
|||
| public function getGroups() | |||
There was a problem hiding this comment.
please add doc comment with return type
| * @method string getGroups() | ||
| * @method Aoe_Scheduler_Model_Job setOnSuccess($onSuccess) | ||
| * @method string getOnSuccess() | ||
| * @method array getGroups() |
There was a problem hiding this comment.
getgroups can be removed from here as it's implemented below.
| @@ -17,9 +17,7 @@ | |||
| * @method Aoe_Scheduler_Model_Job setParameters($parameters) | |||
| * @method string getParameters() | |||
| * @method Aoe_Scheduler_Model_Job setGroups($groups) | |||
| * @method string getGroups() | |||
| * @method Aoe_Scheduler_Model_Job setOnSuccess($onSuccess) | |||
There was a problem hiding this comment.
why did you remove setOnSuccess and getOnSuccess? these methods are being used
| { | ||
| $groups = $this->getData('groups'); | ||
| if (empty($groups)) { | ||
| $groups = $this->getJobCode(); |
There was a problem hiding this comment.
I don't like it. Its surprising to get jobCode from getGroups getter.
I also don't see a benefit of this change.
In the template you do
if ($_groups !== $_jobCode):
echo $this->__('<b>Crongroups:</b> ') . $_groups;
endif;
which can be simplified to "if ($_groups):" once you remove adding of $this->getJobCode(); to groups, right?
|
@tmotyl This PR is from 3 years ago. I will check and fix the code asap.... |
|
I know :) |
…have many crons with groups